Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Retry Logic I #2396

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Configurable Retry Logic I #2396

wants to merge 29 commits into from

Conversation

Jeffery-Wasty
Copy link
Member

Allows users to configure retries for custom statement errors. This will be followed up with a separate PR allowing the same behavior for connection errors.

@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 80.21201% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 50.45%. Comparing base (f452337) to head (196b65a).

❗ Current head 196b65a differs from pull request most recent head cf98e65. Consider uploading reports for the commit cf98e65 to get more accurate results

Files Patch % Lines
...crosoft/sqlserver/jdbc/ConfigurableRetryLogic.java 80.64% 30 Missing and 12 partials ⚠️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java 75.60% 8 Missing and 2 partials ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2396      +/-   ##
============================================
+ Coverage     49.88%   50.45%   +0.57%     
- Complexity     3827     3883      +56     
============================================
  Files           145      146       +1     
  Lines         33360    33632     +272     
  Branches       5654     5706      +52     
============================================
+ Hits          16642    16970     +328     
+ Misses        14349    14253      -96     
- Partials       2369     2409      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review April 23, 2024 17:50
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Apr 23, 2024
@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.1 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Under Peer Review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant