Bring JUnit Jupiter Assumptions to RequestBoundaryMethodsTest to Avoid Test Case Quiet Quit

[Codegass]

Resolve #2359

Is your feature request related to a problem? If so, please give a short summary of the problem and how the feature would resolve it

When I am go through the test class RequestBoundaryMethodsTest, I noticed that many of the test cases in this test class is using the if condition to determine if a test should proceed based on certain preconditions.

Here is an example from testWarnings:

    @Test
    public void testWarnings() throws SQLException {
        try (Connection con = getConnection()) {
            if (TestUtils.isJDBC43OrGreater(con)) { \\ If Condition is false, then the whole test will quietly finished
                con.beginRequest();
                generateWarning(con);
                assertNotNull(con.getWarnings());
                ...
                ...
            }
        }
    }

This approach can lead to tests passing under conditions where they're not actually validating the intended functionality.

As I checked, all these test cases shared this design pattern in the RequestBoundaryMethodsTest :

• testModifiableConnectionProperties
• testWarnings
• testOpenTransactions
• testStatements
• testThreads

Describe the preferred solution

I would like to propose we adopt the JUnit Jupiter's assumption API to handle such precondition checks. The assumption API allows tests to be skipped when certain conditions are not met, making it clear that the test result is not applicable under those conditions. So here we can use the assumption api to replace the if condition without quiet quit. (If the assumption is false the TestAbortedException will be recorded).

For instance, the testWarnings case can be refactored as follows:

@Test
public void testWarnings() throws SQLException {
    try (Connection con = getConnection()) {
        Assume.assumeTrue(TestUtils.isJDBC43OrGreater(con));

        con.beginRequest();
        generateWarning(con);
        ...
        ...
}

This change will make test results more accurately reflect the behavior being tested, as irrelevant tests are skipped rather than falsely passing.

PR Implementation

The change will be straightforward and involves replacing if statements with Assume.assumeTrue in all five test cases.

Reference Documentations/Specifications

Junit5 Assumption Doc

[codecov]

Codecov Report

Attention: Patch coverage is 67.02703% with 61 lines in your changes are missing coverage. Please review.

Project coverage is 49.83%. Comparing base (9a8849b) to head (4ccbfee).
Report is 20 commits behind head on main.

❗ Current head 4ccbfee differs from pull request most recent head 2dbd726. Consider uploading reports for the commit 2dbd726 to get more accurate results

Files	Patch %	Lines
...a/com/microsoft/sqlserver/jdbc/SQLServerError.java	32.14%	17 Missing and 2 partials ⚠️
...microsoft/sqlserver/jdbc/SQLServerInfoMessage.java	44.44%	14 Missing and 1 partial ⚠️
...m/microsoft/sqlserver/jdbc/SQLServerException.java	64.28%	5 Missing ⚠️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java	50.00%	3 Missing and 1 partial ⚠️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java	80.00%	3 Missing and 1 partial ⚠️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java	84.00%	3 Missing and 1 partial ⚠️
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java	73.33%	2 Missing and 2 partials ⚠️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java	33.33%	1 Missing and 1 partial ⚠️
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java	50.00%	1 Missing ⚠️
...oft/sqlserver/jdbc/SQLServerPreparedStatement.java	87.50%	0 Missing and 1 partial ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2382      +/-   ##
============================================
- Coverage     50.03%   49.83%   -0.20%     
- Complexity     3785     3822      +37     
============================================
  Files           143      145       +2     
  Lines         33204    33360     +156     
  Branches       5629     5654      +25     
============================================
+ Hits          16613    16625      +12     
- Misses        14207    14368     +161     
+ Partials       2384     2367      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.