Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape schema for getProcedures and getProcedureColumns in SQLServerDatabaseMetaData #2369

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Mar 26, 2024

No description provided.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 85.96491% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 50.15%. Comparing base (7e0dcb3) to head (adba1fb).
Report is 6 commits behind head on main.

❗ Current head adba1fb differs from pull request most recent head 0666524. Consider uploading reports for the commit 0666524 to get more accurate results

Files Patch % Lines
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 80.00% 3 Missing and 1 partial ⚠️
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2369      +/-   ##
============================================
+ Coverage     50.09%   50.15%   +0.05%     
- Complexity     3814     3825      +11     
============================================
  Files           145      145              
  Lines         33291    33340      +49     
  Branches       5639     5651      +12     
============================================
+ Hits          16677    16721      +44     
- Misses        14226    14230       +4     
- Partials       2388     2389       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Mar 27, 2024
barryw-mssql
barryw-mssql previously approved these changes Mar 27, 2024
@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Mar 27, 2024
@lilgreenbird lilgreenbird changed the title Escape schema fix Escape schema for getProcedures and getProcedureColumns in SQLServerDatabaseMetaData Mar 27, 2024
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Mar 27, 2024
MSSQL JDBC automation moved this from Under Peer Review to In progress Apr 2, 2024
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Apr 2, 2024
@Jeffery-Wasty Jeffery-Wasty merged commit 1f0d85a into main Apr 2, 2024
17 checks passed
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Apr 2, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the escape-schema-fix branch April 3, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Connection.getMetaData().getProcedures does not handle schema as a pattern
4 participants