Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if TDSCommand counter is null before incrementing. #2368

Merged
merged 3 commits into from
Apr 2, 2024

Conversation

Jeffery-Wasty
Copy link
Member

Prevents #2353.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 50.09%. Comparing base (7e0dcb3) to head (4716d69).
Report is 3 commits behind head on main.

❗ Current head 4716d69 differs from pull request most recent head 5b94ee5. Consider uploading reports for the commit 5b94ee5 to get more accurate results

Files Patch % Lines
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 33.33% 3 Missing and 1 partial ⚠️
...oft/sqlserver/jdbc/SQLServerBulkCSVFileRecord.java 80.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2368   +/-   ##
=========================================
  Coverage     50.09%   50.09%           
- Complexity     3814     3823    +9     
=========================================
  Files           145      145           
  Lines         33291    33324   +33     
  Branches       5639     5649   +10     
=========================================
+ Hits          16677    16694   +17     
- Misses        14226    14238   +12     
- Partials       2388     2392    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

barryw-mssql
barryw-mssql previously approved these changes Mar 27, 2024
@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review March 27, 2024 17:39
@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Mar 27, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Mar 27, 2024
@Jeffery-Wasty Jeffery-Wasty marked this pull request as draft March 27, 2024 18:44
MSSQL JDBC automation moved this from Under Peer Review to In progress Apr 2, 2024
@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review April 2, 2024 17:35
@Jeffery-Wasty Jeffery-Wasty linked an issue Apr 2, 2024 that may be closed by this pull request
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Apr 2, 2024
@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.0 milestone Apr 2, 2024
@Jeffery-Wasty Jeffery-Wasty merged commit bea8daa into main Apr 2, 2024
17 checks passed
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Apr 2, 2024
@Jeffery-Wasty Jeffery-Wasty deleted the npeInCounter branch April 2, 2024 21:01
@Jeffery-Wasty Jeffery-Wasty added this to To Backport in 12.6.2 Hotfix Apr 5, 2024
Jeffery-Wasty added a commit that referenced this pull request May 17, 2024
@Jeffery-Wasty Jeffery-Wasty removed this from To Backport in 12.6.2 Hotfix May 17, 2024
Jeffery-Wasty added a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

NullPointerException on reconnect with lockTimeout configured
4 participants