Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassLoader leak of ActivityCorrelator ThreadLocal #2366

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Conversation

lilgreenbird
Copy link
Member

address issue reported in #2136 where ActivityCorrelator ThreadLocal never being removed from the thread.

@lilgreenbird lilgreenbird added this to the 12.7.0 milestone Mar 25, 2024
@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.15%. Comparing base (8e92248) to head (892ef1a).
Report is 2 commits behind head on main.

❗ Current head 892ef1a differs from pull request most recent head e6b3e5f. Consider uploading reports for the commit e6b3e5f to get more accurate results

Files Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2366      +/-   ##
============================================
+ Coverage     50.10%   50.15%   +0.04%     
- Complexity     3813     3823      +10     
============================================
  Files           145      145              
  Lines         33286    33299      +13     
  Branches       5639     5641       +2     
============================================
+ Hits          16677    16700      +23     
- Misses        14221    14240      +19     
+ Partials       2388     2359      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Mar 26, 2024
tkyc
tkyc previously approved these changes Mar 26, 2024
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Mar 26, 2024
@lilgreenbird lilgreenbird dismissed stale reviews from Jeffery-Wasty and tkyc via e6b3e5f March 26, 2024 21:42
MSSQL JDBC automation moved this from Under Peer Review to In progress Mar 26, 2024
@lilgreenbird lilgreenbird changed the title Fix ClassLoader leak Fix ClassLoader leak of ActivityCorrelator ThreadLocal Mar 26, 2024
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Mar 26, 2024
@lilgreenbird lilgreenbird merged commit f626adf into main Mar 27, 2024
17 checks passed
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Mar 27, 2024
@lilgreenbird lilgreenbird deleted the threadlocal branch April 3, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants