-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear prepared statement handle before reconnect #2364
Conversation
@microsoft-github-policy-service agree company="Raiffeisen Software GmbH" |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2364 +/- ##
============================================
+ Coverage 50.03% 50.13% +0.09%
- Complexity 3804 3828 +24
============================================
Files 145 145
Lines 33304 33360 +56
Branches 5641 5655 +14
============================================
+ Hits 16665 16726 +61
+ Misses 14248 14242 -6
- Partials 2391 2392 +1 ☔ View full report in Codecov by Sentry. |
thank you for submitting this I have marked this for review |
private void clearPrepStmtHandle(){ | ||
prepStmtHandle = 0; | ||
cachedPreparedStatementHandle = null; | ||
if(getStatementLogger().isLoggable(Level.FINER)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting issue. Should have a space preceeding the initila if statement brace and after the closing brace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(getStatementLogger().isLoggable(Level.FINER)){ | |
if (getStatementLogger().isLoggable(Level.FINER)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls run formatter on all files
ignore failing pipelines it's an issue in our test lab |
private void clearPrepStmtHandle(){ | ||
prepStmtHandle = 0; | ||
cachedPreparedStatementHandle = null; | ||
if(getStatementLogger().isLoggable(Level.FINER)){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if(getStatementLogger().isLoggable(Level.FINER)){ | |
if (getStatementLogger().isLoggable(Level.FINER)){ |
aee03c1
This fix clears the SQLServerPreparedStatement.prepStmtHandle before reconnecting.
The provided interface can also be used for other objects that need to handle reconnecting.
One test fails: PropertyTest.testRetryCount:54->testInvalidPropertyOverBrokenConnection:46 Unexpected error message occurred!Eine bestehende Verbindung wurde softwaregesteuert
durch den Hostcomputer abgebrochen
This might be due to the system being German. The test also failed before the fix.