Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to RMFAIL instead of RMERR #2348

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Default to RMFAIL instead of RMERR #2348

merged 3 commits into from
Mar 19, 2024

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Mar 18, 2024

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 50.13%. Comparing base (eae6d7b) to head (65c4d26).
Report is 2 commits behind head on main.

❗ Current head 65c4d26 differs from pull request most recent head f056aa7. Consider uploading reports for the commit f056aa7 to get more accurate results

Files Patch % Lines
.../microsoft/sqlserver/jdbc/SQLServerXAResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2348       +/-   ##
=============================================
- Coverage     73.56%   50.13%   -23.43%     
+ Complexity     6079     3790     -2289     
=============================================
  Files           143      143               
  Lines         33179    33146       -33     
  Branches       5631     5620       -11     
=============================================
- Hits          24407    16619     -7788     
- Misses         6255    14143     +7888     
+ Partials       2517     2384      -133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jeffery-Wasty
Copy link
Member

Also removed unused getRootCause in Util.java (+java.util.List and java.util.ArrayList imports needed for it) (added in 2nd XA PR [#2132])

@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Mar 18, 2024
@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.0 milestone Mar 18, 2024
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Mar 18, 2024
@tkyc tkyc merged commit 41710d2 into main Mar 19, 2024
17 checks passed
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Mar 19, 2024
@tkyc tkyc deleted the default-rmfail branch March 19, 2024 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

XAER_RMERR still being thrown during SQL Server failover with 12.5.0 despite fixes for issues 2130 and 2159
3 participants