Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed auth dll revert #2109

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Embed auth dll revert #2109

merged 2 commits into from
Apr 25, 2023

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Apr 12, 2023

No description provided.

@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Apr 13, 2023
@tkyc tkyc merged commit 150effe into main Apr 25, 2023
9 of 21 checks passed
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Apr 25, 2023
@tkyc tkyc deleted the embed-auth-dll-revert branch April 25, 2023 20:19
@cboehme
Copy link

cboehme commented Jun 20, 2023

Is there any information available why that feature was reverted? It looked really promising and I was hoping that it could solve my problems with using integrated authentication in the liquibase-maven-plugin.

@tkyc
Copy link
Member Author

tkyc commented Jun 20, 2023

@cboehme There are some licensing issues with embedding the DLL as it uses proprietary code.

@cboehme
Copy link

cboehme commented Jun 21, 2023

Thank you @tkyc, that's a pity.
Wouldn't it be possible to distribute the DLL in a separate jar which uses the same license as the DLL? That way the DLL could still be loaded as a resource from the main driver jar but is not bundled with the MIT licensed driver code. Developers would then only have to include both jars in their applications to enable integrated authentication. This would save them fiddling with java.library.path.

@tkyc
Copy link
Member Author

tkyc commented Jun 21, 2023

@cboehme Thanks for the suggestion. That would work, but I'll need to bring that up to management since it's their decision to make. We're still exploring solutions and nothing has been settled yet, but when we do I'll let you know. It might be awhile as right now this isn't a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants