Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve high thread count when using findSocketUsingThreading #2104

Merged
merged 46 commits into from
Jun 6, 2023
Merged

Resolve high thread count when using findSocketUsingThreading #2104

merged 46 commits into from
Jun 6, 2023

Conversation

Jeffery-Wasty
Copy link
Member

@Jeffery-Wasty Jeffery-Wasty commented Mar 31, 2023 •
edited

findSocketUsingThreading can reach high thread counts for some users. This was due to an uncaught exception.

@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Apr 3, 2023
@Jeffery-Wasty Jeffery-Wasty added this to the 12.3.0 milestone Apr 3, 2023
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Apr 3, 2023
@Jeffery-Wasty Jeffery-Wasty linked an issue Apr 3, 2023 that may be closed by this pull request
Infinite loop in SQLServerConnection.login, spawning thousands of threads, causes high CPU and threads consumption #1831
Closed
@Jeffery-Wasty Jeffery-Wasty moved this from Under Peer Review to In progress in MSSQL JDBC Apr 11, 2023
@Jeffery-Wasty Jeffery-Wasty marked this pull request as draft April 11, 2023 19:36
@Jeffery-Wasty Jeffery-Wasty modified the milestones: 12.3.0, 12.3.1 May 4, 2023
@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review May 16, 2023 17:15
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC May 16, 2023
tkyc
tkyc previously approved these changes May 24, 2023
View reviewed changes
MSSQL JDBC automation moved this from Under Peer Review to In progress May 25, 2023
@Jeffery-Wasty
More debugging earlier on
df47b5f
@Jeffery-Wasty
Edit test
f4690e7
@Jeffery-Wasty
More debugging.
39678c9
@Jeffery-Wasty
Added print statements further up in the call stack.
230b21b
@Jeffery-Wasty
for some reason, we're not logging
a55fd97
@Jeffery-Wasty
More debug
e63515d
@Jeffery-Wasty
Trying without setting localhost in the test as this messes things up.
ab4ec0c
@Jeffery-Wasty
Manually set the iNetAddress to confirm the test is actually running.
d478453
@Jeffery-Wasty
Cleanup
607bdb0
@Jeffery-Wasty
Final cleanup before review.
c51e682
@Jeffery-Wasty
Test cleanup.
4563554
@Jeffery-Wasty
We can't ignore the InterruptedException. If we catch, log, and inter…
3a52c67 
…rupt the thread.
@Jeffery-Wasty
We don't want to continue, we don't to reinterrupt.
0271ba3
@Jeffery-Wasty
A different try with reflection.
66d6467
@Jeffery-Wasty
One more try with reflection.
ae567c0
@Jeffery-Wasty
Exclude junit test from DB and DW.
c44c8d0
@Jeffery-Wasty
whitespace
160f33c
@Jeffery-Wasty
Remove localhost?
770f5e7
@Jeffery-Wasty
Moved back in localhost, otherwise the correct condition is not reach…
9f39702 
…ed, and the multithread route is not used.
@Jeffery-Wasty
Check for localhost + PR comments
dd57d60
@Jeffery-Wasty
...
233100b
@Jeffery-Wasty
Resolve failures that came up after inserting assertTrue() statement
9f3c78c
@Jeffery-Wasty Jeffery-Wasty merged commit 0eec249 into main Jun 6, 2023
22 checks passed
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Jun 6, 2023
@Jeffery-Wasty Jeffery-Wasty deleted the infiniteThreads branch June 7, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@David-Engel David-Engel David-Engel approved these changes

@tkyc tkyc tkyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Milestone
12.3.1
4 participants
@Jeffery-Wasty @lilgreenbird @David-Engel @tkyc