Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failover partner to be tried in case of socket timeout #2100

Merged
merged 14 commits into from
Apr 25, 2023

Conversation

Jeffery-Wasty
Copy link
Member

A socket timeout exception when starting connection led to connection close before failover was being attempted. This allows the failover to be tried once, with the timeout exception being returned if failover can't be connected to.

@Jeffery-Wasty Jeffery-Wasty marked this pull request as ready for review March 27, 2023 20:56
@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Mar 27, 2023
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Mar 27, 2023
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Mar 28, 2023
@Jeffery-Wasty Jeffery-Wasty reopened this Mar 28, 2023
MSSQL JDBC automation moved this from Closed/Merged PRs to In progress Mar 28, 2023
@Jeffery-Wasty Jeffery-Wasty moved this from In progress to Under Peer Review in MSSQL JDBC Mar 29, 2023
@Jeffery-Wasty Jeffery-Wasty added this to the 12.3.0 milestone Apr 3, 2023
tkyc
tkyc previously approved these changes Apr 5, 2023
MSSQL JDBC automation moved this from Under Peer Review to In progress Apr 11, 2023
lilgreenbird
lilgreenbird previously approved these changes Apr 11, 2023
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 20, 2023
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 20, 2023
@tkyc
Copy link
Member

tkyc commented Apr 20, 2023

/azp run public-mssql-jdbc.windows

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft microsoft deleted a comment from tkyc Apr 20, 2023
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 20, 2023
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Apr 24, 2023
@lilgreenbird lilgreenbird merged commit 2d3c393 into main Apr 25, 2023
17 checks passed
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Apr 25, 2023
@Jeffery-Wasty Jeffery-Wasty deleted the socketTimeoutFailover branch May 1, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants