Access token callback #1940
Merged
Access token callback #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyc
force-pushed
the
access-token-callback
branch
from
1926cbe
to
c3c3fd6
Compare
tkyc
commented
Oct 27, 2022
| providerName), null, 0, false); | ||
| throw new SQLServerException(null, String | ||
| .format(SQLServerException.getErrString("R_CustomKeyStoreProviderValueNull"), providerName), | ||
| null, 0, false); | ||
| } | ||
|
|
There was a problem hiding this comment.
Everything above this comment is just formatting changes.
David-Engel
reviewed
Nov 2, 2022
src/test/java/com/microsoft/sqlserver/jdbc/connection/NativeMSSQLDataSourceTest.java
Show resolved
Hide resolved
lilgreenbird
reviewed
Nov 3, 2022
src/main/java/com/microsoft/sqlserver/jdbc/SqlAuthenticationToken.java
Outdated
Show resolved
Hide resolved
…dded missing comments
|
Multiple comments have leading hyphens, I don't think we do that anywhere. Please remove them for consistency. |
src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerConnection.java
Outdated
Show resolved
Hide resolved
...zureactivedirectoryauthentication/src/main/java/AzureActiveDirectoryAccessTokenCallback.java
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/ISQLServerDataSource.java
Outdated
Show resolved
Hide resolved
Jeffery-Wasty
previously approved these changes
Nov 3, 2022
lilgreenbird
previously approved these changes
Nov 3, 2022
…mssql-jdbc into access-token-callback
Jeffery-Wasty
previously approved these changes
Nov 3, 2022
Jeffery-Wasty
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows client code to register a callback for DataSource that returns an access token.