Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed callable statement index out of bounds error; Fixed parameter not defined error #1898

Merged
merged 11 commits into from
Aug 22, 2022
Merged

Fixed callable statement index out of bounds error; Fixed parameter not defined error #1898

merged 11 commits into from
Aug 22, 2022

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Aug 17, 2022

For #1871

  • Fixes callable statement index out of bounds
  • Fixes callable statement parameter not defined error

@Jeffery-Wasty Jeffery-Wasty linked an issue Aug 17, 2022 that may be closed by this pull request
Wrong parameter count after CallableStatement#setObject(String, Object, int) #1871
Closed
@Jeffery-Wasty Jeffery-Wasty added this to In progress in MSSQL JDBC via automation Aug 17, 2022
@Jeffery-Wasty Jeffery-Wasty added the Under Review Used for pull requests under review label Aug 17, 2022
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Aug 17, 2022
@lilgreenbird lilgreenbird added this to the 11.3.0 milestone Aug 17, 2022
Jeffery-Wasty
Jeffery-Wasty previously approved these changes Aug 18, 2022
View reviewed changes
MSSQL JDBC automation moved this from Under Peer Review to In progress Aug 19, 2022
@tkyc tkyc merged commit 51dabe3 into main Aug 22, 2022
MSSQL JDBC automation moved this from In progress to Closed/Merged PRs Aug 22, 2022
@tkyc tkyc deleted the callable-many-param-fix branch August 22, 2022 20:19
@Jeffery-Wasty Jeffery-Wasty removed the Under Review Used for pull requests under review label Aug 22, 2022
@lilgreenbird lilgreenbird mentioned this pull request Dec 5, 2022
Merged
tkyc added a commit that referenced this pull request Dec 14, 2022
@tkyc
Fixed callable statement index out of bounds error; Fixed parameter n…
02a6f01 
…ot defined error (#1898)

* Fixed callable statement index out of bounds error; Fixed callable statement parameter not defined for sproc error

* Comment correction

* Removed unnecessary concat

* syslogins does not work on azureDB, switched to sql_logins

* Ignored on azureDB and added comment

* PR comment changes

* Reduced to one liner

* Addressed more PR comments

* Corrected error resource name
@lilgreenbird lilgreenbird mentioned this pull request Dec 14, 2022
Merged
@JackPGreen JackPGreen mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

Assignees

@tkyc tkyc

Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Milestone
12.1.0
Development

Successfully merging this pull request may close these issues.

Wrong parameter count after CallableStatement#setObject(String, Object, int)
3 participants
@tkyc @lilgreenbird @Jeffery-Wasty