Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed query cancellation bug that intermittently occurs in batch queries #1897

Merged
merged 4 commits into from Aug 16, 2022

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Aug 15, 2022

Fixes #1896

doExecutePreparedStatement() isn't affected because it doesn't execute TDS requests one after the other eg. It doesn't do batching.

@tkyc tkyc force-pushed the batchquery-query-cancellation-fix branch from 0ce968b to 56a76a9 Compare August 15, 2022 23:17
@lilgreenbird lilgreenbird added this to In progress in MSSQL JDBC via automation Aug 16, 2022
@lilgreenbird lilgreenbird moved this from In progress to Under Peer Review in MSSQL JDBC Aug 16, 2022
@lilgreenbird lilgreenbird added this to the 11.3.0 milestone Aug 16, 2022
@tkyc tkyc merged commit bc30270 into main Aug 16, 2022
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Aug 16, 2022
@tkyc tkyc deleted the batchquery-query-cancellation-fix branch August 16, 2022 19:39
tkyc added a commit that referenced this pull request Dec 9, 2022
@tkyc tkyc mentioned this pull request Dec 9, 2022
tkyc added a commit that referenced this pull request Dec 12, 2022
* Backport of #1897 - batch query cancellation fix

* Updated SQLJdbcVersion file

* 10.2.2 updates for pipeline testing

* PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Canceling "insert into" statement closes connection
3 participants