Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using org.hamcrest due to module issues #1596

Merged
merged 1 commit into from Jul 13, 2021
Merged

Avoid using org.hamcrest due to module issues #1596

merged 1 commit into from Jul 13, 2021

Conversation

cheenamalhotra
Copy link
Member

org.hamcrest classes fails to resolve to module and below module conflict each other:

  • org.hamcrest.core
  • hamcrest.core

Steps to reproduce:

  • Right click and select "Create module-info.java"
  • All other classes are resolvable except org.hamcrest classes

If it's not absolutely needed, tests can avoid using these Junit APIs as standard alternatives are available.

@lilgreenbird
Copy link
Member

/azp run Microsoft.mssql-jdbc.macOS

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@cheenamalhotra cheenamalhotra force-pushed the hamcrest branch 2 times, most recently from c32ac37 to 0a1b802 Compare June 9, 2021 17:56
@lilgreenbird lilgreenbird added this to Under Peer Review in MSSQL JDBC Jul 2, 2021
@lilgreenbird
Copy link
Member

/azp run Microsoft.mssql-jdbc.windows

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@cheenamalhotra cheenamalhotra merged commit 551a90a into dev Jul 13, 2021
MSSQL JDBC automation moved this from Under Peer Review to Closed/Merged PRs Jul 13, 2021
@David-Engel David-Engel deleted the hamcrest branch August 1, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
MSSQL JDBC
  
Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

None yet

4 participants