Exclude JDBC 43 tests from Java 8 build

microsoft · Jul 29, 2021 · a5af949 · a5af949
1 parent 8a65c61
commit a5af949
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/pom.xml b/pom.xml
@@ -254,6 +254,10 @@
 								<exclude>**/com/microsoft/sqlserver/jdbc/SQLServerJdbc43.java</exclude>
 								<exclude>**/com/microsoft/sqlserver/jdbc/SQLServerConnection43.java</exclude>
 							</excludes>
+							<testExcludes>
+								<exclude>**/com/microsoft/sqlserver/jdbc/connection/ConnectionWrapper43Test.java</exclude>
+								<exclude>**/com/microsoft/sqlserver/jdbc/JDBC43Test.java</exclude>
+							</testExcludes>
 							<source>1.8</source>
 							<target>1.8</target>
 						</configuration>

diff --git a/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerJdbc43.java b/src/main/java/com/microsoft/sqlserver/jdbc/SQLServerJdbc43.java
@@ -30,20 +30,22 @@ static final void throwBatchUpdateException(SQLServerException lastError,
                 updateCounts, new Throwable(lastError.getMessage()));
     }
 
+    private static double jvmVersion = Double.parseDouble(Util.SYSTEM_SPEC_VERSION);
+
     static SQLServerConnection getSQLServerConnection(String parentInfo) throws SQLServerException {
         return jvmVersion >= 9 ? new SQLServerConnection43(parentInfo) : new SQLServerConnection(parentInfo);
     }
 
-    private static double jvmVersion = Double.parseDouble(Util.SYSTEM_SPEC_VERSION);
-
     /** Client process ID sent during login */
     private static int pid = 0;
 
     static {
-        if (jvmVersion >= 9) {
-            long pidLong = ProcessHandle.current().pid();
-            pid = (pidLong > Integer.MAX_VALUE) ? 0 : (int) pidLong;
+        long pidLong = 0;
+        try {
+            pidLong = ProcessHandle.current().pid();
+        } catch (NoClassDefFoundError e) { // ProcessHandle is Java 9+
         }
+        pid = (pidLong > Integer.MAX_VALUE) ? 0 : (int) pidLong;
     }
 
     static int getProcessId() {