This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Fix microsoft/monaco-editor#1576 update dependency to core #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependency to monaco-editor-core to 0.18.0
* Fix typing errors:
* SignatureHelpAdapter#provideSignatureHelp return a wrapped SignatureHelpResult
* monaco.languages.DocumentSymbol has got a new property: tags
The tags are an array SymbolTags, and the only existing SymbolTag is "Deprecated".
I did not find any information about that in the ts.NavigationBarItem, so the tags
are always an empty array for now.
|
Thank you! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/monaco-editor#1576
The tags are an array of
SymbolTags, and the only existingSymbolTagis "Deprecated".I did not find any information about that in the
ts.NavigationBarItem, so the tagsare always an empty array for now.