This repository has been archived by the owner on Nov 5, 2021. It is now read-only.
Add a rename provider #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spahnke
commented
Aug 14, 2019
|
|
||
| // --- rename ---- | ||
|
|
||
| export class RenameAdapter extends Adapter implements monaco.languages.RenameProvider { |
There was a problem hiding this comment.
There is another optional method resolveRenameLocation in the interface which I didn't implement. What is the purpose of this method and do we need that?
| if (!(renameLocation.fileName in fileNameToResourceTextEditMap)) { | ||
| const resourceTextEdit = { | ||
| edits: [], | ||
| resource: monaco.Uri.parse(renameLocation.fileName) |
There was a problem hiding this comment.
You cannot use monaco.Uri.file here; it leads to the error "bad edit - model not found".
orta
approved these changes
Aug 29, 2019
spahnke
force-pushed
the
rename-provider
branch
from
b8f9fa8
to
ceff666
Compare
|
Thank you! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers a
monaco.languages.RenameProviderwith the Monaco Editor for a safe way of renaming symbols. Feedback/recommendations welcome!Fixes microsoft/monaco-editor#300
The rename operations currently suffer from the same problem as code actions and cannot be undone (see microsoft/monaco-editor#1548).
I also get the following warning on the browser console after the rename operation is applied. Any suggestions for the cause of that? (Monaco version 0.17.1)
Thanks!