Add config to disable default formatter

[domoritz]

fixes microsoft/monaco-editor#889

[domoritz]

@aeschli is this what you imagined?

[aeschli]

Having it as part of DiagnosticsOptions is strange.

Maybe a Capabilities property on the LanguageServiceDefaults? Also there needs to be code that listens to the change event and register/unregister the formatter.

[domoritz]

Thank you for taking a look at my PR. I updated it to follow your suggestions.

[aeschli]

Thanks, improvements are good.
I would still suggest to have a new settings options Capabilities and have 'formatter` in there, so we can use that object also for other requests to not register some features.

Also, now onDidChange is fired, but isn't it necessary to listen to it and register/deregister the services?

[domoritz]

Oh, I misunderstood your comment and didn't read Capabilities as Capabilities. I'll work on this.

I had assumed that this._onDidChange.fire(this) would reload the services. I guess I have to keep a reference to the services/providers so that I can deregister them, right?

[domoritz]

What are the disposables for, btw? The array doesn't seem to be used anywhere.

[domoritz]

Done. Let me know if this is what you imagined.

Btw, I noticed that the indentation is inconsistent (space vs tabs). What's the preferred indentation?

[aeschli]

looks good!
should be tabs.
yes, there's currently no way to uninstall the language supports, so the disposables are not used.

[domoritz]

I can remove disposables if you want or just leave it. Other than that, I'm done with the PR.

[aeschli]

Thanks, I'll take it from here!

[domoritz]

Thank you. Monaco is really awesome and especially the JSON support has been phenomenal for the editor we are building (https://vega.github.io/editor/).

[domoritz]

Typo. Should be "whether".

[domoritz]

same typo as above (also note the same typo below)

[aeschli]

@alexandrudima Here's what we ended up with the APIs to enable/disable certain providers in JSON.
Let me know if that makes sense for you.

[domoritz]

Any updates on this @aeschli @alexandrudima?