Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ts-node #3001

Merged
merged 1 commit into from Mar 2, 2022
Merged

Upgrade ts-node #3001

merged 1 commit into from Mar 2, 2022

Conversation

andrewbranch
Copy link
Member

monaco-typescript builds of TypeScript 4.6 and nightlies are failing due to a TS API change that ts-node needed to account for: microsoft/TypeScript#47921 / TypeStrong/ts-node#1648. The ts-node fix was just published to v10.6. We need this in order to get new versions of TypeScript up on the playground. Thanks!

@mjbvz mjbvz requested a review from alexdima March 2, 2022 01:22
@hediet
Copy link
Member

hediet commented Mar 2, 2022

Thanks for the PR!

However, I find it strange that a build-time dependency to ts-node can cause such problems.
Is this because ts-node requires typescript as peer-dependency and there was a breaking change in a typescript version that is compatible with ts-node's version constraint of that peer-dependency?

@hediet hediet merged commit db5039b into microsoft:main Mar 2, 2022
@andrewbranch
Copy link
Member Author

@hediet exactly. ts-node has a peer dep of typescript@>=2.7, and we had an API breaking change.

@andrewbranch andrewbranch deleted the upgrade-ts-node branch March 2, 2022 17:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants