Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hyphenated HTML tags in Markdown syntax #2864

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

rcjsuen
Copy link
Contributor

@rcjsuen rcjsuen commented Dec 30, 2021

This fixes #2863.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@hediet
Copy link
Member

hediet commented Jan 3, 2022

Thanks for your PR!

@hediet hediet merged commit a385674 into microsoft:main Jan 3, 2022
@rcjsuen rcjsuen deleted the md-hyphenated-html-tags branch January 3, 2022 11:46
@rcjsuen
Copy link
Contributor Author

rcjsuen commented Jan 3, 2022

@hediet Thanks for the review. Have a nice day! :)

@andrewspy
Copy link

I have tried with the latest (v0.32.1) release, but the syntax highlighting of <custom-component> still not working as expected. Am I missing anything?

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Feb 5, 2022

I have tried with the latest (v0.32.1) release, but the syntax highlighting of <custom-component> still not working as expected. Am I missing anything?

@andrewspy It seems to work on the website for me.

image

@andrewspy
Copy link

@rcjsuen You are right! Sorry for asking the stupid question before testing it on the main site. I'll check my toolchains.

Thanks!

@andrewspy
Copy link

@rcjsuen Is there an API to get the version string of Monaco Editor? Need it to make sure I'm using the latest version, and I can't seem to find it in the API DOC

Sorry to bother you again.

@rcjsuen
Copy link
Contributor Author

rcjsuen commented Feb 6, 2022

Is there an API to get the version string of Monaco Editor? Need it to make sure I'm using the latest version, and I can't seem to find it in the API DOC

Not sure. Maybe you can look at your node_modules folder and check the markdown.ts file to see if you've gotten the change for starters.

@andrewspy
Copy link

@rcjsuen Managed to resolve the issue, I am using @monaco-editor/loader, and it was loading an older version of the code online.

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support syntax highlighting of <custom-component>in markdown
3 participants