Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling slow on Ubuntu 16.04 + Firefox 68.0.2 #1575

Closed
paul-marechal opened this issue Sep 5, 2019 · 1 comment
Closed

Scrolling slow on Ubuntu 16.04 + Firefox 68.0.2 #1575

paul-marechal opened this issue Sep 5, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Milestone

Comments

@paul-marechal
Copy link

monaco-editor version: 0.17.0/0.18.0?
OS: Ubuntu 16.04

On Firefox (68.0.2) the mouse scroll is really slow (maybe 10 times slower?)

I tried capturing a gif, but I cannot scroll fast enough for it to show on the capture.

Chrome (76.0.3809.132) is not affected.

Tested on the playground as well: https://microsoft.github.io/monaco-editor/playground.html

@joechung-msft
Copy link

joechung-msft commented Sep 5, 2019

It seems to be scrolling by pixel instead of by line of text.

It also happens in Windows 10 (x64) and Firefox 69.0.

@alexdima alexdima added this to the August 2019 milestone Sep 18, 2019
@alexdima alexdima self-assigned this Sep 18, 2019
alexdima added a commit to microsoft/vscode that referenced this issue Sep 18, 2019
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Sep 18, 2019
alexdima added a commit to microsoft/vscode that referenced this issue Sep 30, 2019
GongT added a commit to kendryte/kendryte-ide that referenced this issue Oct 17, 2019
99ba33dc9d Potential fix for #82611
e02e20c3ce strict property init (#78168)
6a2d035b71 revert console logs
0aa9168957 fix issue with scroll-y submenu being 10px
aeb909a3b3 Fix build
4ccccc25c4 strictFunctionTypes work, #81574
c21f5c293b update padding on compact menubar fixes #82668
a8461cf10f strictPropertyInit refs #78168
39b3e8799d Add support for overlapping brackets (#26121)
c941854fb4 Better support for begin/end style brackets (#26121)
c6b09780bd Allow bracket matching to search across multiple tokens
2205002a2c Fix icon ref in problems view automation tests
e576dc7604 Merge pull request #82019 from bmalehorn/remove-search-configs
02a3cf3485 Remove unneeded re-creation of comment titlebar on update
4b63d31d51 fix GDPR annotation
c8cda3110a Fix commentController context key scoping, fixes #82711
d026f7bc6d Rename ReviewController to CommentController
cd955c2770 Pick up latest js/ts grammar
db1434f05b Show basic webview editors contributions section
8c4e2206d9 Fixing some possible leaks in electron webviews
9016354769 Refactoring onResourceEditorOpening
f222010664 Mark currently active editor type in reopen with
6e90f387d1 Fix #51816
8a806778ea fix #49465
a97e8c31d7 debug: show breakpoint hint when hover over line
9a90668906 Fix unit test
d52ff8c4e8 Don't show quick pick when there's only one task to configure
55afde9a02 Fixes #53357
082e88004e Merge branch 'joao/yarn-electron'
5bb817dccb Fixes #32616: Add surrounding pairs to plaintext
61867d90d9 Fixes #82674: Improve setImmediate shim
d6bf4a9aec fixes #60644
9289dd7842 remove yarn gulp electron
4aee31efe2 Switch to use a notification when the max computation time is reached
86ea9e1d6b :up: chokidar@3.2.2 (#82686)
2ddcbf4306 fixes microsoft/vscode-remote-release#519
cb88dfc67f Use execFile for Linux to terminate task
405cf46520 strict property init (#78168)
198b3a28da Make Run web task beginsPattern slightly more specific
0b69ef1e77 debt - less async / await
e7b9c03552 Rename diffEditor.maximumComputationTime to diffEditor.maxComputationTime
0a55dcfccb Show hint when the diff algorithm quits early
3fc780dc7c debug more async/await
042caca100 Add `diffEditor.maximumComputationTime`
5048816ebf extract yarn electron
37d462bfa1 Add IDiffComputationResult.quitEarly
12e5b2f305 :lipstick:
44811c0969 Fixes #70578: terminateProcess() should not use cp.spawnSync() or cp.execFileSync()
be68a4e14c distro
6b0613aaba Merge pull request #82529 from Krystofee/added_random_snippet_variable
ed32bc2d41 status - do not show encoding picker so early
d961010ebf electron 6 - adopt 'high-contrast-color-scheme-changed' event
0fc787b94c Fix launch config name
c144ea6c14 Merge pull request #82642 from microsoft/tyriar/xterm_update
06f94fb46c Swallow resize error if terminal already exited
12b93934ca Support fast scroll in terminal
e2341917a4 Fix undefined errors with xterm elements
2290bae501 xterm@4.2.0-beta10
f462eab969 Adding builtin priority for custom editors
89e4d3eddc Add setting to configure the max memory for tsserver (#82630)
5c705ea7ee Fix #82199, resetting some color of code blocks at Markdown Preview with light theme (#82453)
5a44cf8b6d Remove unused import
773d2205da Mount webviews on the root of the workbench
31506b5899 Remove old portMapping api conversion logic
d4cebcd450 Move filling in of default localResourceRoots into extHost
dc9ca65375 Use instanceof checks
f406e199c4 :lipstick:
b2e7c5b658 Remove unused import
1391a834b8 Remove empty layout methods
5ab75d2da3 :lipstick:
e08b22ba73 Extract reviveWebviewExtension
c142b04817 Prefer using the name `webviewInput` for variables that manage WebviewInput objects
019bce14ec Remove extra handler for onDidUpdateState
431f446b5b Use Schemas
1c2e5df289 Convert static class to constant
01dcd28add Extract InternalWebviewViewType
48195455a1 Remove the setExtension helper
84d62ea8a3 Add launch config/task for "yarn web"
43e85c223c xterm@4.2.0-beta8
9f6db37cca Merge pull request #82613 from md2perpe/patch-1
3d143cc7b0 Merge branch 'pr/66522'
d5664e35ed cleanup commit template, merge
03bc3fa4f4 :up: distro
4a80681a01 Merge commit 'refs/pull/66522/head' of github.com:microsoft/vscode into pr/66522
1548f74c70 fix hygiene
c417a4874a fixes #82362
ada8bd61b5 Add missing preposition
887528397c :lipstick: code-web.js
5e5bb4ad30 :lipstick:
cd16f82b83 fixes #82294
e4e1312476 do not run only ResourceTree tests
a9f66e01a1 debug more asyn await
017e7dfb61 Merge pull request #82209 from w9jds/feature/#75938
1273a257d7 explorer: more async await
aaa9fab2d6 debug: pointer cursors so breakpoints appear as clickable
d9e93a7067 Merge branch 'joao/fix-82264'
246896965f fix scm resource folder actions
db5892f51e Render progress bar after 1s of diff computation in diff editor
dc56bd9d1c debug commands: asyn awati
ed193fcb42 debug: more async await
3bbd6bfd03 debug configuration manager: asyn await
b8bc8accf5 fixes #82564
49129e9911 Allow to run web client out of sources (#82569)
11daba9b00 Feature/pin close others (#82545)
911eabf34a debt - properly type network.ts
385bf0f0e8 Merge pull request #80684 from solomatov/disposables-10-09
2f37e87f4c Merge remote-tracking branch 'origin/master' into disposables-10-09
3f6ed25939 Actually update Octicons with correct mapping
8f6eb88d4d Windows Edition in Workspace Stats (#82539)
3e1276cb51 Merge pull request #82377 from microsoft/fix/php-custom-tags
ecdba243ff Treat non-spacing marks as part of word in md files
a0fd93ac46 dont reposition overflow menu when it doesnt move fixes #82078
9048856bf3 Fixed: Image preview should not zoom on first click if unfocused (#82074)
0e6b372987 Added RANDOM, RANDOM_HEX snippet variables
3d3202804b update distro
e4a4ea2b26 Keep track of the diff computation state
0d9307ff59 fix resource rewrite before host available fixes #82467
f6668e808a Close process explorer on cmd/ctrl+w, fixes #64373
9f2ca57b05 Fix #82199, numbers hard to read in light theme markdown preview (#82450)
2c535a36e9 focus first item on submenu mnemonic fixes #82470
8447937abb Merge pull request #82380 from solomatov/change-new-terminal-title
5767f6f21b minimap - allow variable scaling (#82265)
aad1e68331 Merge pull request #82395 from microsoft/misolori/monokai-theme
12625aaffd Merge branch 'master' into misolori/monokai-theme
c534a1cea9 Fix #64684
55aa1de95c Revert ":up: graceful-fs@4.2.2 (#82058)"
cbf7642083 Map 'stop' Octicon to 'error' Codicon
a65701ec2e strict null
774a6b0b6b Update Codicon icon mapping for Octicons
3cc2460c3b debug: more async await
460ef3a4a6 debug session: more async await
7485ffde50 Some polish for 'Run NPM Script in Folder'
aa9a4820e6 Merge branch 'helen3141-runNpmFromContextMenu'
8ddfe42838 fix #78202
68bf7d7297 :lipstick:
563d56cbd2 fix #69637
ce720bbbb0 web - fix spelling mistake
b2157cbe2e Revert "Revert "debt - adopt new fs.readdir with stat info""
21cda4e0f0 chokidar - ignore *.asar by default
e06de411d2 fixes #82359
40aed75986 fix #56651
b9438bb3a6 fix #41691
2e5e00128c extHostDebugService: Enable `strictPropertyInitialization`
9fe70996f7 fix #65561
7b1cedcfe4 fix #82491
ba82bddd89 remove unused
9c7f7d60e7 debug: do not report errors from configurationDone
26225a3f4c partsSlash: latest theme colors not persisted on color change
cc49f34f42 workbenchThemeService: Strict property initialization (#78168)
617ca966a7 Remove bad test assertion
081ba54144 Strict property initialization (#78168)
03dd464b47 Command line error - "Option 'proxy-server' is unknown. Ignoring.". Fixes #82253
a6511f9955 Revert "Fix strictFunctionTypes errors in terminal proxy"
5e61bbd54f Recent Workspaces list broken with UNC paths and root of a drive. Fixes #74362
5a24d13624 Update highlight js and md versions
664fe8f910 Show preferred action info in lightbulb hover
592e0ca271 Remove more duplicated types
9a8be02e5d Use normalized  path for loading remote webvie resources
3d716c20e2 Fixes #45131: Render a floating click widget when the diff editor has whitespace only changes and whitespace is ignored
f9a37b406a Avoid excessive Promise.resolve
e85b326d5c Add DiffEditor contributions
7b9364af5d Improve labels (#45131)
d783f9ec2d strictPropertyInitialization in comments, #78168
e27cc21299 fix #65561
ceeb587991 fix #82491
9b52e74045 remove unused
d17d837007 debug: do not report errors from configurationDone
826a5ca408 partsSlash: latest theme colors not persisted on color change
9c6ff9bbfa workbenchThemeService: Strict property initialization (#78168)
78aaebf8b6 Remove bad test assertion
79fa4f988c Strict property initialization (#78168)
f93d34e4c5 Command line error - "Option 'proxy-server' is unknown. Ignoring.". Fixes #82253
a30e88aca1 Revert "Fix strictFunctionTypes errors in terminal proxy"
77b9203327 Recent Workspaces list broken with UNC paths and root of a drive. Fixes #74362
acdbc65fcc Update highlight js and md versions
c5d138ec28 Show preferred action info in lightbulb hover
2a8cc9c067 Remove more duplicated types
aeca02ae3c Use normalized  path for loading remote webvie resources
643e57fb73 Fixes #45131: Render a floating click widget when the diff editor has whitespace only changes and whitespace is ignored
97e5b23bfa Avoid excessive Promise.resolve
fb043c53c6 Add DiffEditor contributions
72a57179ff Improve labels (#45131)
818a508ce2 Partial revert
58c941c9c8 strictPropertyInitialization in comments, #78168
34648a0cc6 Merge branch 'master' into runNpmFromContextMenu
c8fe7709a7 Fixes #64579
34e03dda66 Fixes #63553: Repaint decorations when the modified editor's tab size changes
a7ff5b1ac8 Pull Request feedback: do not show command in command palette
1f01e888f2 debt - Avoid Number.MIN_VALUE and Number.MAX_VALUE
cecda63be5 Pull Request feedback: updated documentation and naming, read from cache if available instead of creating new tasks
78fd1e5ec2 php - fix break statement not reducing indent level
85fe047664 Tweak Monokai colors for diff views
b6b011b294 php - increment indentation for inline php tags
988077fc2c Fix #82298, this.getConnection is not a function
0d065af185 adopt font window icon controls (#82301)
867bcaee0d php - fix identation drifting on empty single-long blocks
72f3185301 php - open executable settings if the validator fails
f3d4a67c2d Center scm text, badges, and icons
fb82295959 Fix #74681
4a81920398 Revert "scm: make tree rendering opt-in via proposed API"
7d32d508fd Open New Terminal -> Open New External Terminal
debaebba50 Update Chrome icons to render correctly on Windows
f840384927 php - fix custom tags appearing invalid
bede31d0d9 resource tree: support data in branches
3ee53ad714 Fixes #69238: Avoid placing the hover above the page
7680bfc470 Merge pull request #82198 from microsoft/misolori/activity-bar-active
372e76a727 Merge branch 'master' into misolori/activity-bar-active
b880553e5e Fix #82165
f26a2e84d1 Fixes #65281: Treat the presence of \w as an indicator of a multiline regex search string
2d87c95e53 Don't show task quick pick for 'show' command when only one task
a69811751d Merge pull request #82349 from yamachu/fix/suggest-over-remove
4425701a16 Add tasks setting to turn off all task auto detection
cc100aa664 Add ability to have OS specific task problem matchers
5a63e286a7 fixes #82346
a7f3a3732e more :lipstick:
13584cceaf :lipstick:
dc4b1c231c Rename CustomExecution2 to CustomExecution
6251b1c226 Update pull_request_template.md
cc6d174f7c Add task end fire so that executions are cleaned up
d952f6bfc1 Fixed the problem of overwriting many characters in suggestion
1cd8dce12c Create pull_request_template.md
be89df857d Add busy tasks and check busy tasks in debug
59abaab728 Fixes #75345: Do not write to the selection clipboard when restoring selection state
95ebd1a17d Fixes #49693: Disable column selection with middle mouse button if selection clipboard is enabled on Linux
412dd1077f Merge branch 'master' into misolori/activity-bar-active
72bc289d32 Fixing unit tests
5fe2dad8b2 minimap - invalidate cache to ensure colors are updated on theme change
4448d83f00 Update Codicons, add chrome icons and update arrows size
5b0cdadc87 Revert "Build VS code using TS 3.7-beta"
c72179f6c4 minimap - fix confusing showSlider description (#82287)
9e24cb32cf Only show active-item-indicator on activity bar, make it flush
11f24f64e7 Build VS code using TS 3.7-beta
d80739df02 Fixing TS 3.7 dom typings errors
495633ccc5 Make Lazy use an interface more similar to IdleValue
54c29559e5 Remove webview.update method
3310b78eae Be more lazy about creating webviews
bc87a615d4 Introduce Lazy<T> for representing a value that is resolved when it first actually needed
2793bdd296 Fixing cycle
9c3d060aff Rename webviewEditorService to webviewWorkbenchService
12e72de9e4 Reuse LazilyResolvedWebviewEditorInput for custom editors as well
b9e08fa6fa Fix name
6af56c7214 Extract type alias
3ed36f094b Removing duplicated code
43dea5be0f Simplify array equals checks
e78245a5d4 fixes #82257
22b8925963 Merge branch 'master' into misolori/activity-bar-active
23956cc5e2 update to electron 6.0.x (#81644)
41db44ff34 Fix #68453
346416d6c2 only left click on menubar fixes #81954
e8d9892d20 panel pref dimensions fixes #82018
b1190cb5d0 Don't allow dirty state button to be clicked when running without close button
80dc6d1067 Show dirty state icon when tabCloseButton is off
7816110c15 Specify exact icon path for deb desktop
c3e909d5a5 Separate HTML for selection inner corners from remainder of selection (#82182)
afa911d942 scm: make tree rendering opt-in via proposed API
e80d909439 scm: don't use ResourceTree model if view mode is List
675c8d8ec4 Fix #51816
d67491f546 Update color tokens
7e57821af2 Terminal and part of the debug changes needed to respond to cancelling a prelaunch task (#82255)
1dd67cb2ce Merge pull request #82103 from nikeee/fix-executable-bits
7152672e3f debug commands: better fix for checking if threadId is a number
f51b40808a Fixes #49305: Call preventDefault on mouseup event for middle button when selectionClipboard is turned off
db3dd377f0 debt - migrate suggest filtered types setting to many dot form
fcd4e09fd4 make overwrite suffix the default, #10266
3a626d89a0 shift+tab/shift+enter overwrite suffix when accepting a completion, #10266
13dc6f18ac Add setting to turn off problem matcher prompt
b6138b9526 Fixes #80825: Use &nbsp; only on Windows
2703975994 Make it easier to tell which status item will be disabled in context menu (fix #76544)
e6af73db94 debugCommands: check if threadId is number before using it
9f0d6a6d17 Yield every 1 ms from tokenization (fixes #40681)
dd9fe15849 notifications - hide toasts when filter is on
76db3ee4b7 Use setImmediate for yielding from tokenization
ad3267819b zen mode: silentNotifications
d32da8db59 [folding] configure plain text to use offSide folding. Fixes #73444
e5cb7e9d2e fixes #81361
61079a9db5 Fix bad empty string on commandLine in task types
c484b25720 notifications - allow to configure a filter to silence notifications
f60e33e182 tweak undo behaviour when inserting suggestion via commit character, fixes #44155
a8ec0bb74d Upgrading a theme currently requires a window reload. For #73306
3b473663d9 comment
7ab14b67e6 fixes #82212
c0aee71269 native tabs require macOS 10.13 at least
52fc24aad3 add outline.filteredTypes setting, #53034
18dcbcc22e add breadcrumbs.filteredTypes-setting, #69279
42d95e583b json ls-server readme: typos
3da9bcbb78 JSON Language Server 1.2.2
e921f24fc8 use window.setTimeout
8dc5474066 [themes] Debounce color theme selection. Fixes #71616
a1dfbaa9d8 Merge branch 'master' into feature/#75938
98984d476b Merge branch 'master' into misolori/activity-bar-active
ab7d961f1d Notifications icon polish (#82171)
1b77eb9969 Added in setting for diff gutter visibility
ffaaf4fe0d :lipstick:
0575dd40d9 improve static argv configuration (#15211)
5943d065e3 Hide active elements in HC mode
38b235b35c Update description
7dea3f12b5 Use unique dom element to style active activiy bar elements
193fead410 Fix #82192
c0bd994bc7 Fix PHP indentation rule for 'case' Fix #81107
ecb1de1afe update gdpr tag for measurement
2da0921c2c Fix #76203
7a42d5a6ab Fix #76862
654bf10dbd Merge pull request #82184 from gregvanl/FindAnIssue
7aae845a6a Add a link to Where to Contribute Fixes #74102
dfee0337a5 Merge branch 'master' into fix-executable-bits
6032e84542 Strict property initialization errors for comments panel, #78168
11b28d3872 Disallow reloading in issue reporter. Fixes #77171 (#82131)
6e8ff27ea6 Use mustable disposables
21ba436c51 Fix one more case of #81320
588576d8dd Fix #82123
4e53af222f Fix #75349
8e574096ad Add color tokens for active activity bar elements
ab0eb6de2d Fixes #82153: Allow `editor.fontLigatures` to contain font-feature-settings
e1f09b528c [themes] Disabling default themes results in empty label name. Fixes #56702
b73f9ec854 Add a setting to disable gpu acceleration (fixes #15211)
841d89748a [rust] provide auto indent pattern. Fixes #51802
b853eed359 Remove unused params
33bd3a1e75 Merge pull request #82162 from microsoft/tyriar/72649
65dd040a65 Remove minimum terminal split width guard
13d3f41417 [html] Format code of type="text/babel" scripts in html files. Fixes #39866
2990a8f4d0 :up: distro
710be19dbf Revert ":up: distro"
3831ba8c0a :up: distro
d1be9d02cd :lipstick:
4ce64ef558 Merge commit 'refs/pull/80335/head' of github.com:microsoft/vscode into pr/80335
ecea71432f fixes #73613
27177c51e0 fixes #72973
861d56b788 fixes #82149
4885946e19 debt - more async/await
6e52c2f1f9 cancel rename all the way, fixes #82146
c2d3f4284f add overload that allows to cancel a cancellation token when calling dispose
e5b8c2f08d Update listPaging.ts
dad5d39eb0 debt - cleanup main.js
9502b4c390 Only enable re-open with command when we actually have a custom editor for the current resource
82599cc6bd Add extra clairification about where displayName is used
20654cccf1 Marking IMarkdownString.value and isTrusted as readonly
90b66c889c fix: remove TypeScript from ExtensionSuggestions (#82125)
8f3b739bf8 Merge pull request #82072 from IllusionMH/pcre2-for-whole-word-82071
4332203005 Update distro
bd576990da More strict parsing of codicons
7530116ccf Merge pull request #82046 from microsoft/joh/sigusr1
877ce7ac03 Introduce allowChords setting
4fe9987925 Support chords in terminal
ab713cac34 fixes #68713
a5b9969f06 Merge branch 'master' into joh/sigusr1
65f5f14ff7 change scm default from tree to list
eaedd52763 Merge pull request #82101 from microsoft/aeschli/eol_languagespecific
002e2192b5 Fixes #74722: When there is a selection, never paste on new line
eb9fe80de6 when editing c#, typing /* causes */ to be injected. Fixes #43989
52649cbefe Call open on Terminal after attach to DOM
465d9489d2 Attach element before calling open in test
9e5c2aca23 fixes #67814
38fc105e4d Merge branch 'master' into aeschli/eol_languagespecific
3117c154b3 Update xterm and xterm search
7ba9113425 Update default eol on language change if model has no eol yet
94adc2a641 Repair npm links (#70325)
f0faef0dd7 Merge pull request #82097 from jplatte/patch-1
23059a783e dev - add husky back for git precommit hooks
1cc0b592c2 Remove executable bits from non-executable files
d9a639a06b fix hygiene
e4a66a8698 strict null
daaf92b5bc [shellscript] Make \n the default eol. Fixes #49418
273d62f2e7 Make `files.eol` overridable. Fixes #49418. Fixes #34876
5cd301d403 :up: distro
c3e1bcc67b :up: distro
0fc92f222f fix tests
c109bf77ac linux/bin/code.sh: use command -v instead of which
b24844ce9d Fixes #72823: Do not compute char changes for huge chunks
e57a82771b Pass the elements to the diff algorithm directly
84167ad509 Add ISequence.elementsAreEqual
c4821bf4a0 Use Int32Array
55610696fe Avoid allocations for ISequence.getElementAtIndex
e80b0f53fa :lipstick:
807a126a6a remove pseudo breadcrumbs in call hierarchy peek, #81859
46be30ef9a renames: source -> from, target -> to, #81746
178b598c82 Merge pull request #82062 from kondratyev-nv/master
c270a67615 Terminal should scroll to bottom on reused task terminals
b8a26a0139 debt - tweak proposed API check (#82089)
b78fe0cc1e :up: distro
42ebd1036f build - use enable-proposed-api in tests
bcaa2be1b5 outline progress bar delay is average respone time, some minor polish, fixes #63400
a6ac3e5634 Revert "fixes #77837"
e9cc9c7847 debt - make debugging lazy services simpler
79722879ba debt - less null in workbench
10545c3a92 Fallback to PCRE2 if match whole word used with regexp
4a79a0ba40 Fixing a few more strict init errors in panelViewlet
6fdd8d10dc Fixing strict init errors in webview code
4388300e89 Cache webview web contents
953d193378 Removing zoomFactor logic for webviews
b0dccbcf75 Marking a bunch of static variables as readonly
90f33ddc6d Use DisposableStore in a few more places
095358e3b2 fix image preview to show correct canvas size when editor is scaled down vertically (#82027)
2719c1ddc0 Replacing more for loops with .every/.some or arrays.equals
4e2caaa646 Use array.find in more places of re-implementing it with for loops
d1b81e23db Remove applicationinsights-web dependency
99dc069a0c Remove another duplicated array equals helper function
30dc021bf7 null -> undefined
40e0f496f9 Use equals helper function instead of re-implementing it so many places
6e593ab812 Converting some search for loops to use .some/.every instead
4a461d267f Converting a few functions in ITokenizationRegistry to return undefined instead of null
948af79e49 Markding results from panelService as readonly
de9a8a67b3 Converting some parts of panel service to return undefined instead of null
ab3f2e6180 Use find instead of for loop
02ae385856 Convert getPanel to return undefined instead of null
a660620e88 Convert null -> undefined
73d2f81d13 Mark that pendingComment can be null, #81574
3c70da4c8c :up: graceful-fs@4.2.2 (#82058)
6869239fd8 :up: terser@4.3.8 (#82057)
4c4edcefeb Fixing more TS 3.7 related compile errors
2b4638e1ac Fix missing function calls in condition
9f90a1d69c Fix more TS 3.7 dom typings errors
1f7e445625 Fixing more issues related to TS 3.7 dom typings changes
e4ec151881 Fixes more issues related to strictFunctionTypes
61cd8be9e3 Call resolveCommonTelemetryProperties in browser version of telemetry service
111b4dccff debug: more async / await
0634ecc229 Merge pull request #81923 from microsoft/misolori/icon-font-problems
7d6b20b7d2 Merge branch 'master' into misolori/icon-font-problems
a51693925e fix compile error
e14c86a791 Add a useful message for when background tasks don't have a watching problem matcher
2d713ac3a5 debug: more async await
f380a8b047 Simplify fix for #12574
0d895b5bb8 debug: more async await
491eb9bbaf Add logic for negative custom tree view highlight numbers
443f36dd97 Fix broken matches in custom tree
4fb9d0dbdc Don't show folders with trailing slash in simple file dialog pick
bc8346120d fixes #81662
a634057990 Uppercase drive letter on Windows simple file dialog
5847d75aad fixes #81879
c474303556 Remove .txt from save as simple file dialog
ad597a4791 Merge branch 'master' into joh/sigusr1
56087d67e3 debt - strict function
32b2861498 workaround - remove `as const` to make webpack happy...
5d413d7418 remove --disable-inspect
d212bf7c0b simplify find port, remote hacky env variables
28402eb956 Update sql language syntax (#77601)
85f70fd2de Merge branch 'master' into joh/sigusr1
5fe0604806 enable strictFunctionTypes
511137f876 Merge pull request #79764 from hwhung0111/issue-79428
2d96b9b616 Fix global tasks again
84786d378c distro
0f2cda10da support to enable inspector when asking for inspect port and consume in auto extension profiler
2ca00003a6 expose `enableInspectPort` in starter type
32b4eb7359 Add .har extension to JSON language (#77300)
d82755c650 remove used method
0cfba55686 add enableInspectPort-method which uses sigusr1/_debugProcess
c1e90f3475 more strictPropertyInitialization
2b0a7df9da strict function types
3ba1fe28a0 Revert "Fix customView.ts for strictFunctionTypes"
4fe8b82907 Fix customView.ts for strictFunctionTypes
cb0dc7680e debt - more strict init (#78168)
66eea492f8 debt - introduce and use assertDefined for strict init (#78168)
e9ee372447 debt - reduce usage of strict null bypass
06c10cddf0 Strict init for tasks in extHostTypes.ts
d9935e0dfe Merge pull request #81840 from kondratyev-nv/master
6c9cf76929 Remove unused styling code
93cfe48a3f Strict property initialization (#78168)
56c472e185 strict init
999d8f97df Merge branch 'joh/next'
50c2639b86 Merge branch 'joh/strict'
d73a2f7a88 debt - less defense
904ab2364e in extension land prefer URI.isUri, fixes  #81819
e257fad18a deco - some debt, add logging
c71cbdaa1b Render Octicons in CodeLens
e6e04b2810 search: remove unused config settings
c617db19b0 debt - some strict function types (#81574)
875fc151e2 web  - store font info properly
ae891b59bc web - do not reload if workspace is equal
fc7727b0d3 debt - move out reload/quit to lifecycle service
a3d77034dc debt - no need for explicit closeWorkspace()
45856f0eba debt - windows => windowsMainService
1602957aa2 debt - remove no longer needed code
ffbc48855a debt - add whenClosedOrLoaded into window class
86a42393b0 debt - handle window errors in window class
c55d704a14 debt - move pick & open into electron main service
ff09b48de3 Merge pull request #81975 from youngyou/patch-1
45c4f22894 Fixing more issues related to #81574
8e944be15c Support jsonc for code block type with highlightjs
36aa903d5a Rewrite how we handle links in the md preview
7f5a4a3f5b Fix strictFunctionTypes errors in terminal proxy
a0c6566f87 Fix strictFunctionTypes errors in terminalService
4ddddcfb6d Fix strictFunctionTypes errors in terminalInstance
a967c8ada3 Move js/ts json validation to js/ts language features extension
e1011ffcc8 Marking event properties as readonly
dc0ab50035 Use isEqual for comparing uris in more places vs .toString()
7e70b1dda0 Mark that preferredEncoding can be undefined / not initialized
a7ddb97e91 Fix strict property init in parameterHintWidget
92514c469c Fix a few more issues related to #81574
30120e4db6 Dont pass undefined as boolean
831800d6d8 Make sure we also change webview theme data when editor config changes
b9693027bb Use switch case
7f044c7903 Memoize webview theme data
d08130d4d3 Remove some extra not null checks
41a26f0322 Fixing some TS 3.7 dom typing errors
05de12c548 Bump version
a46c17e5b9 Update button.ts
94c9c09627 Update syntax
c310c24e58 Allow labels being triggered by the bot
c06c223ee9 more strict init work
c8252b63f5 Revert "fixes #80054" (#81942)
c836d5ae38 Include icons in the extension viewlet
d3eb24828e Use strict compare for checking if an editor is active/visible
eacd477ea9 Only reuse existing custom editor input if we are opening an editor in the same group
bac36e97c6 Close image preview when file on disk is deleted
ef698fa6cd Make markdown refresh more stable
c7650e66b2 Merge remote-tracking branch 'origin/master' into misolori/icon-font-problems
6e59411265 Add margin for peek icons
56c2540154 Fix typo
6a62058aae Cleanup dead code
d4e49567f3 Update html language service
8266e1c67b Fix #81843
b88efcac1d Bump node2
ef381e5573 Fix #81916
17db07b22c Adopt icon font in problems panel and error peek view
9a8f867129 Use `name` for custom editor title for data uri resources
096eb643d1 Fixes #81876 (#81885)
355676f84f Fix #79840
2b9bb7c2e0 Update css language service
4f6e116539 Use yarn compile for start scripts
8892774174 Fix configuration resolver test
58c72545cd explorer: add decoration provider to disposables
e0729a52ab Fix to many messages whn cancelling resolution of contributed variables
53d6601137 strict init
6ff7bf27c9 Fix settings conflict when opening files locally
6a90438f02 WSL window opening with windows path.  Fixes https://github.com/microsoft/vscode-remote-release/issues/1537
6bbe006248 :lipstick: telemetry opt out
84391a4685 remove product.welcomePage
229df29bc9 Update README.md
3b5e571ef5 fixes #81868
925f3ab1a0 fixes #81871
bb9beb73b0 automatically assign debug issues to isidorn
31a8a2c26e update distro
a655c0836d Bump distro
1628c72806 Run oss tool
10309701ff Don't show webview overlay by default
f137abf254 Update distro, fix web smoke test folder
d84015cc4d Change event name to type
615e262789 Fix git smoke tests
2cf9921ee5 Fixing name and description for custom editor on data uris
b8869cd989 Fix git diff view for untracked image files showing an error on left side
d91209b356 Fix image views not being activated properly
2235ebf5db Handle new vscode-resource format for md linkes
e28affc16b Fix preferences smoke tests
e568cf539c Fix search smoke tests
8f83fbaa2d Update distro
790c574ce4 Fix microsoft/vscode-remote-release#1573
f7efcef2be Fix #81845
a1b7714d26 Schema for attached container configurations (fixes microsoft/vscode-remote-release#1577)
e2f1ee3573 fixes #81838
b058a2831a Correctly style image loading indicator for various themes
b7cc9ca822 Update md grammar
e5557b7e6e Reapply c057a4b9c73ce820e0c1a02797bf9f06bd638e86
ab529dcd83 fixes #81852
0f4875f5e7 fixes #81846
2943151b3a fixes #81567
085e845f22 limit panelview animations to expansion
89dd1725e3 fixes #81727
1e7a92b119 Fix double prompting for default build task when canceled
2f06eb9855 Fix #79116
a8a448d166 fixes #77837
fb10f85b4c fix #81653
75e6fa0797 Add completion suggestion for defaultBuildTask
1d8037c63c Update default build task placeholder text for defaultBuildTask variable
c850f0716e fixes #81798
a8fc2bd9be fix #81763
f52667b249 Add to jsdoc for TreeView message
d09090927e fixes #81731
c5e2892b29 urls - add option to disable confirm dialog
57aea60efd toggle fold to use cmd+k cmd+l shortcut. Fixes #81795
d5ddcf10bf update gulp-tsb, https://github.com/microsoft/vscode/issues/81140
888f86f156 null guard
689e2fd320 fix compile
741323bbb7 fix #81323
38d52c3eaa migrate parameter hints setting, #81256
2f28b4074a Revert "continue to suppor legacy parameter hints config,  #81256"
bb0dbb3b9c fix vscode.open() tests (#81833)
46043d41c8 continue to suppor legacy parameter hints config,  #81256
ddcdb9dd66 json: provideFormatter fix
1f70a46308 fixes #81715
d859157d39 Merge pull request #81297 from jeanp413/fix-snippet-tranformation-escape
1dd2e64c3f Merge branch 'master' into fix-snippet-tranformation-escape
ca8a10ba8c fix #80754
b0aecd3843 handle auth errors
46098598fe fix #81137
ff42be5d56 remove 64 bit suggestion
695ee74864 doh
3f21572d6a comment out test
8eaec303ea Revert "Make sure we dispose of any custom editor inputs when replacing them"
c057a4b9c7 Make sure we dispose of any custom editor inputs when replacing them
a25c6e6660 Add CSP
f735e062f3 Rename custom editors discretion to priority
04d0cf6ad6 Show errors when image can't be loaded
aeae28bf2c Remove tiff as a supported image preview format
c241e1d5e4 Making status bar items for images more reliable
47ac64a019 Make sure status bar name for zoom/size can be localized
b3da545c1d Use enum to track preview state to avoid getting into invalid states such as active & disposed
6493b8dc0a Make sure active is set to false when webviews are disposed
72c8590b39 Make sure zoom status bar selections only effect the active image
214ee89df0 Use isEqual instead of tostring compare
af070ee0a0 Move custom editor extension activation out of input
64023bd18b Show loading indicator while a custom editor is resolving
ccf0a56243 Fix #81704
dc5a137ec4 Use US English in settings sync
73c61c4e40 Update high contrast minimap selection color, fixes #81728
f96527a7bd Document `mime` for custom editor selectors
5bd8022122 Merge pull request #81781 from skprabhanjan/fix-81779
3793cb96e9 Improve docs on asExternalUri
00b1067cab Add simple description for image preview extension
197c7f2718 Fix #81701
e1aa754e6f Fix #81790
eedf80d84b Re-render image preview when image on disk changes
9341df363a add cancel id for custom dialog
011186efc7 Changed hyphen and underscore ordering
27d7141d28 Revert "Changed hyphen and underscore ordering"
a3fc301dc4 Changed hyphen and underscore ordering
9c1fa6f48e Fixes #81762
e520a1bcef make sure all, not some, decorations are unused before removing its css rule, #81467
2966f6f05d update distro
85cfc55a69 Tweak wording of minimap.selectionHighlight description, fixes #81730
62b2b7098d Update jsdoc for TreeView title
20876ae53b telemetry - fix broken opt out
2724ca6c05 styler: allow Color
313ede61cb Also remove extHostWebview side of the api proposal for webview editor state/save
f75285a4e1 Remove `save` / `state` from custom editor api proposal for now
71c95a466f Disable open with command for now
9bb24dc1c1 Upgrade html/css language services
fe0f0cc501 Fix monospace font-family not showing in deeper hover/suggest
2aea209a3e Add fallback for invalid signature help data structure
9cba8ad16d fixes #81267
1c215ef3f6 Try different name for default editor
f832acfbd9 Settings editor fixes - Fix keyboard shortcut to show context menu - Fix showing gear icon when settings row is focused
48e1250e2f Fix #81690
df0953c045 Fix setting row colors Remove focus outline on settings editor. It's not tabbable so it doesn't serve any purpose and is annoying to see every time I click on the editor background. Just need to keep .editor-instance from getting focus on click. Fix #81675
e904a5f646 Warn development webview extensions that use `vscode-resource` uris directly
8079ff0001 Rename resolveExternalUri to asExternalUri
3ae6f0bf93 Annotate that `preferredEncoding` can be undefined
74ac7b8520 smoke: update mocha
1465409125 update json server & service
d6169488c3 update html server & service
ecba37c6ef update css service/server
b8a75a33dd Fix #81573, show beak in status bar
a5745f5042 [folding] Support single shortcut for toggling fold/unfold. Fixes #18549
3f3a9e30db Fix #81536, center git decorations
7a27b26446 Polish css.completion.completePropertyWithSemicolon doc
889d69688b Update Octicons and cgmanifest
2c704846d6 Show correct icon in HC mode for adding breakpoints
83cd86bb36 Fix #81649, show collapse icon in debug viewlet
3611cc7d07 Show collapse icon in Problems panel
d26bc6e7d5 Fix #81662
eb5ec0fd2a Suggest linebreak. Fix #79840
5f8dec837f enable auth by config
22caeb97a4 handle v6 ip addresses in remote-resources rewrite
665ac1da33 Clean up Gesture.addTarget
3577fd0fab Merge branch 'master' into runNpmFromContextMenu
531522b76e A readOnly editor doesn't honor readonly in the textArea (#81394)
bae6f5f1a5 [json] "Fetch Online Package Info" feature doesn't work when npm is not present. Fixes #77066
69ae6cdf21 Only use the readonly attribute on the web
ec10d47a57 Merge remote-tracking branch 'origin/master' into pr/ElasticPencil/81394
846fefe1b7 Merge branch 'master' into runNpmFromContextMenu
2de9a3629f Fixes #72798: Transport other error types (not just instances of Error)
4ca2a270fd Add touch events to minimap (#81097)
fa5c6386eb Fixes microsoft/monaco-editor#1575: respect deltaMode
a7b0732a03 Hide require.toUrl call from ESM packagers
3ff057ce33 Fix the shape of insane.js to make it ESM compatible (microsoft/monaco-editor#1574)
fe9e05d8d7 Adopt ILogger.flush() (#80862)
215df67b0f Try to use the remote port number locally (microsoft/vscode-remote-release#1115)
361cf8edec Handle 0.0.0.0 too (microsoft/vscode-remote-release#1115)
af2126c725 support `code --remote ssh+remote+xy /pathOnXY`. For https://github.com/microsoft/vscode-remote-release/issues/585
29f0d108bf Fixes microsoft/monaco-editor#1553
50701eee93 Merge pull request #81606 from larshp/link_update
111c29c085 Merge pull request #80895 from mjbvz/use-const-enums-for-suggest-dto
79978f96d3 Fix #81152
6b3006104a debt - if one workbench contribution fails to load, do not fail to load all others
0e8d8e2d60 Move built task keybinding registration earlier
501416814e fixes #80816
da76f05e7a electron - revert to Electron 4
78a6b2d72f #81592 again
9964824ef9 do not stop if it was not running before
8d9356eaa5 Telemetry when exe recommendation is already installed
c2997da2ac Gesture.addTarget returns an IDisposable
5c3ac79b01 fix "extension slow" link
4ea33570b1 update-distro
42846298e2 Fix #81468
080a1fa86f Fix #81535
205b617cac web - implement text input actions too
078acb7872 JSON formatting often fails at first. Fixes #71652
846cff1e8f Fix #80862
09836b5a84 Undo change to scope/coloring of #includes in cpp
459f2071e5 tslint - show warning when using path module from node.js
e02f5dcebb debt - use dialog main service in more places
25fb4bcd78 debt - move enterWorkspace into workspace service
65c65e2697 debt - introduce and use dialog main service
f8cdbe7421 host - reduce methods that are required
7928b7fb00 debt - move ISharedProcess
304693f37e debt - async import for cli
3a01780e9e Merge pull request #81609 from vedipen/saveAllAndCommitFix
3259fbf267 [json] Use textDocument.rangeFormatting.dynamicRegistration instead of workspace.symbol.dynamicRegistration? #81592
601e3e0762 Merge pull request #81572 from shifuchen98/typo
6138fdc0cb Update monaco.d.ts
6a0c40a0cc save all and commit fix
78c37ee454 editor, modes.ts: fix broken link
7e18b80180 Merge branch 'master' into typo
314d67c15b :lipstick:
821af7875b Merge branch 'master' into fix-snippet-tranformation-escape
f2d41726ba Mark that preferredMode can be undefined
74e4847b51 Extract BrandedService type
42b59f5017 Fix strict function type error for registerLanguageCommand
3dc33a7901 Extract constant
3160940d25 Fix typo in batch replacement pop-up
56109c8aef fix console error when compact and navigating menu
d98f650edf Merge pull request #81570 from microsoft/misolori/icon-font-settings
e7d40dd837 Merge branch 'master' into misolori/icon-font-settings
408a3eb7bb Add loading indicator while image is loading in image preview
a939a80c4a Center gear icon
9b3c041552 Center icon actions
cedc081e73 Remove dead styles
4b16948148 Allows icons to inherit color
7292718c5e Adopt icon font in settings
6f070c5a35 Update icons in Keybindings editor
62f6fe49c3 Hide settings editor row highlight interaction with editor focus outline Partially fix #81564
cfb8230a9e register platform services directly
ece510a532 fix enablement
16e01aa522 clean up
dee65ce687 respect disablement state
eb0518fdb9 Fix auto sync enablement
e707a51d85 Merge branch 'sandy081/settingsSyncAuth'
39fa5f4f7d fix layering issue
82d5c682c5 - Add disablement state for auth token - Extract user data sync workbench contribution - Make actions, notifications & badge respect states correctly
1c865c7a9d notificiation to sign in
ad5e5815ab web - introduce workspace provider
64396bf622 adopt to auth token service
57484e5d2b Introduce auth token service
1f80e3954c debt - extract node only window options
00fa26ef00 :lipstick:
b0bfcce0e8 Wire up configuration of user and workspace tasks
f733d1c3c1 add logs
3f7bd94525 debt - lift a few service implementations from platform to workbench
f39e5c3c13 fix build
a2352c83b1 debt - adopt ipc proxy for launch service
0f6305f4b2 debt - adopt channel proxy for localizations
ad1a0e6d9f debt - move ipcChannelCreator into ipc.ts
f132464a79 debt - adopt proxy channel for URL channel
d7ed9381ac Update commands.yml
95af84339d :up: distro
268aadc7dd Update commands.yml
6ee1da3dc5 debt - shuffle things around
4e4cb81c57 debt - merge workspaces and history into one
fc7f5753ad ipc - add tests for channel proxy
fa9c39ae35 Web: update PWA theme_color dynamically based on theme
e0762af258 Move webview content state into webviewPanel instead of webviewEditor
e5efdb4b4b Expand documentation for typescript.tsdk
9b1bc4f06a Remove unused properties
1ef51e2c0e Add explicit types
c9ee5111a2 Marking events readonly
06dedcd016 Prefer using isEqual over string compare of uris
d9950173c1 Draw image border for custom image editor
1077b27ce7 Extract method
0fb42f7ab2 Draw shadow for diff view with custom editors
71f4f39092 Mark event fields as readonly
3974fee167 Bail early in mime check
d8748101e3 Use isEqual instead of string compare
2c373c2aac Fix edit icon in keybindings
ff63dd119b Fix #81491, rotate splut terminal icon when panel is on right
d34109e2ba #80862 Add an option is spdlogger for sync logging
bfcc5ad1cc no background change for compact menubar
381603c76c Merge pull request #81505 from microsoft/misolori/octicons
ff8614ec6c Merge branch 'master' into misolori/octicons
af76be4405 Rename remoteAuthority to remoteName for views contribution point
effbd9b1a8 Merge pull request #81442 from davidreis97/78984
2e88aaf19e Renamed onListMouseDown and onListTap functions to onListMouseDownOrTap in SuggestWidget
5dc057df59 Upgrade emmet helper deps for #77776
e193a680e3 debt - reduce isWeb usages
136dbe9e20 debt - move native dialog options
9178de5e30 Merge branch 'master' of github.com:Microsoft/vscode
1e47bb781d Update loading spinner to animate on icon element
64eed745f5 :lipstick: move a few services around
199aa4f22a Inherit color for search viewlet icons
a3801764e3 :lipstick: move things around
ba3613e903 Update Octicons to new style
632115a4d6 Merge pull request #81446 from microsoft/misolori/icon-font-tree
f74b414527 Merge branch 'master' into misolori/icon-font-tree
b3175f5159 update distro commit
9ff086de4f Merge pull request #81451 from microsoft/tyriar/xterm_update
1b0af82dfc clean up
7772da02d2 add logging to sync service
2bc357c2ee Remove callback property from custom execution task
86f3a07e29 debt - rename platform/history => workspacesHistory
bb8416a5d7 debt - separate browser and desktop workspace editing service
bd361ab127 web - implement events for recently opened
8e99945e41 debt - get rid of windows service
a036c0f273 debt - introduce and use workspaces history service
969e23ed64 add logs for extensions syncing
383d5fe103 add logging to settings sync
50ec968a0a do not use arguments
e77bded9cf Introduce output log channel for configuration sync
7fd99d1186 Merge branch '78984' of https://github.com/davidreis97/vscode into 78984
dca80c5d87 Switched TouchStart event by GestureEvent (Tap) so that scrolling is possible on touch devices
156b5fd4f5 update - optionally use electron environment service
328869d618 Make changes to tasks to allow tasks from User Settings and workspace file (#81469)
3f38682210 :lipstick: electron environment service
003a09848e debt - introduce IElectronEnvironmentService
66753ac3ee tests - remove unused test things
01b5fe023e debt - remove windowId from window service
428550903f scm: fix decoration padding
3fcf9d7eae remove casting bufferlogservice
89d3447460 fix colorized unit tests debug target
b0d714d2de Merge pull request #81392 from dgozman/on-did-change-repl-elements
6d93382115 fixes #81432
5c5bdd39b9 Revert "Mark arrays used in public apis events as readonly" (#81465)
ee5e407dcf debt - have config exporter as workbench contrib
1c039f6da3 :lipstick: main entries
98bdf8c51b update distro
f239d28539 Make build task default
4907854f2e debt - avoid raw channel use
f0b99530c8 debt - implement window events and focus tracking
4a596b4431 Update distro
722dd9ac15 Revert "Revert - remove getActiveWindowId change"
cd90f80b3e Remove customEditor.scheme contribution point
f7274467ca Fix compile error in extension
c25e7e90f0 Making IFileChange readonly
af4e34851f Make FileChangesEvent immutable
a4ab394ae5 Mark arrays used in public apis events as readonly
a3420f633e Marking almost all instances of TextFileModelChangeEvent[] as readonly arrays
7dd55cc6b1 Making arrays in event as readonly
8558f4cbb3 Fixing unittest for asWebviewUri
13574e60d8 onMarkerChanged firing with immutable array
0b8142ed26 Use isEqual instead of toString compare
4d7e3514c6 Make availableFileSystems a readonly array
edea1d6394 Don't use null | undefined types in rename
c2e7944f5f Adopt new xterm write callback
75e56b8c6c xterm@4.1.0-beta8
e30cce9eb1 Merge pull request #81449 from microsoft/tyriar/ev
a794e6999a Resolving feedback
08701110b1 Make launch and config files separate events
f1c4cd549f Also dismiss rename input when cursor position changes
6b947b14ed Fix image preview extension for remote
a2ed64badb Adding workaround for chrome bug
0506f7f736 Make sure image views (and custom editors) work properly on the web
fd9528257e Make sure we use consistent unique ids for custom editors
0d10581bfa Make report async
a47bf2ac21 Fix link tests
f9adc5e5a7 Add enableFileLinks setting to avoid expensive FS calls
ac7bbceba5 Split event into multiple
46b364c7d9 Update twistiesContainer
cfb29b8cf7 Merge branch 'master' into 78984
6c1cebbb24 Fire onDidChangeReplElements directly from ReplModel
fa8083bb32 Update icon twisties to work with file icons
1bdd7077a0 Add support for touch events on the suggest widget
f45aa1fc1c Add resolveCommonTelemetryProperties option
4a44dd5086 Revert - remove getActiveWindowId change
d483a316ef fix compilation
6031150a95 Stop syncing when disabled
4707a4ca1a fix naming
a6e475abe7 rename to configuraiton sync
21add29eda add setting: scm.defaultViewMode
e51af00de8 :lipstick:
d49dad0e9a Compact menubar option (#80900)
340f7beef9 Fix to allow for optional chain token in completions (#81402)
6c5fdad370 remove my account view
08d40c8f0e ignore settings and extensions
eb01cf558c option to disable settings sync
66cd8438e2 debt - add window events to electron service
6234336b0f ipc - lay foundation for events support
9233b63a1d fix unit tests
13cbbf299d change ignore settings to array
4a16537014 debug: fix call stack commands context
e06678160f fixes #81393
9bc1083d26 reset secondary actions
74731f65aa fixes #81373
dee8d5a671 show my account extensions only when initialized
220ddd6a83 Merge pull request #81336 from dgozman/link-detector
592fc970bf debt - getActiveWindowId is electron only
d0b67392e7 debt - getWindows is electron only
cc036f3f7c debt - remove more unused
a0b9c73565 debt - remove unused
5a60e6fb9b debt - add openInWindow to host
e096ce1b68 debt - implement focusWindow() via host
817eb6b0c7 additional fix for hidden maximized panel refs #80366
1d36a38142 Adopt icon font in tree
367a5a0c59 Improve LinkDetector
0040158a0d Fixing an issue where a ReadOnly editor will still activate the input controls on mobile devices. The underlying cause is the TextArea element is missing the readonly attribute. This change applies the readonly attribute when the editor is created or the configuration changes to editor.readOnly === true.
fb7fb3e5a8 Merge pull request #81319 from IllusionMH/patch-2
684423ea27 adopt to setting sync end point conventions
6052bcbd04 Fix settings editor gear icon
4e293af126 Make sure we pass on options when resolving uri
ab99fbebf8 Merge pull request #81283 from jeanp413/fix-80389
d09b244ef7 Merge branch 'master' into pr/jeanp413/81283-1
c28cf52bef Show preserve case icon in search viewlet
ad601533c5 setting to ignore during sync
a2862cf998 Update icon class for outline panel
ec9d29eec3 Update scm tree filter icons to use icon font
4439aca7fb debt - window max/min is electron only
21958163d3 debt - closeWindow is electron only
48f914fda2 Fix #80419
f837a34bce debt - move enterWorkspace into workspaces service
992f38c0f9 Merge pull request #81198 from microsoft/pine/suggestFocus
841b33600a Merge pull request #81350 from microsoft/misolori/icon-font-explorer
699c708e98 Merge branch 'master' into misolori/icon-font-explorer
89e89dcfae Also fixes #81151 and makes unsupported exclamation icon bigger
5d2d51f43c Fix #81151, make logpoint icon larger
23f2275c23 debt - move openExtensionDevelopmentHostWindow out of window interface
2f2eb547fa :lipstick: service context
4da232a31b debt - move shared process things out into own service
3909604de9 Fix options not making it indo configuring tasks
863c25abc4 debt - macOS touchbar is electron only
8d3e7c6e0e debt - crash reporter is electron only
ff5eabc685 debt - updateTouchBar is electron only
81fed9c360 "Close Remote Connection" command should be in command palette too. Fixes https://github.com/microsoft/vscode-remote-release/issues/1467
e70e7ab51c debt - openExternal() on main is electron only
16f7fe3ee1 fileEditorInput: go with a static memoizer
eed85f6e98 debt - quit() is electron only
a15c0acaa6 web - support "Close Workspace"
cd5625c766 debt - handle title doubleclick is electron only
95bb5eaaad debt - still implement IElectronService interface
03d6cc42cc Merge pull request #81308 from microsoft/joao/fix-80583
f9df1182a6 :lipstick: window id
ae0356e88b Merge pull request #81318 from IllusionMH/patch-1
5e578594f6 Merge branch 'master' into misolori/icon-font-explorer
ab49b9baf2 Fix failing test
4efb5a827c Merge remote-tracking branch 'origin/master' into pine/suggestFocus
9f6a745027 Bump node2
5666547e74 restore maximized panel fixes #79891
8a269f2f73 Merge pull request #81338 from microsoft/misolori/icon-font-search
7fc8cf9d23 Merge branch 'master' into misolori/icon-font-search
08977575bd Don't use es6 api in platform api
863daffe15 New storage keys for panel sizes fixes #80930 fixes #80366
c27c51b542 Add api to get all tunnels from the tunnel service
029009eafd Marking most private emitters as readonly
e8b2096646 Use DisposableStore
565cadac76 Add note on lifecycle of resolved result
31d946dd96 Remove empty public ctors
fccc14ab26 Remove empty ctor
7574d1ddb3 Remove reopen with from editor context menu
51329d2858 register user data sync config only when end point exists
15c2cfab93 :lipstick:
c2e805a729 microsoft/vscode-remote-release/issues/1400 - Disable reload action if ui extension is installed on both - Fix tooltips
9456d2b134 enable reload action test
f030ce94b6 Use values util in map
0719e0ae42 Support initially collapsing remote explorer panes not related to the current remote type Fix microsoft/vscode-remote-release#1426
8cbc95b362 🧹
0861421079 🧹
90c8b1ec12 Merge branch 'master' into pine/suggestFocus
a31aef4ff0 Merge remote-tracking branch 'origin/master' into misolori/icon-font-search
1192573517 Add missing icons
ea6a8ccf4c Avoid using Set.keys
748f644911 Fix tests after 00983bcdf0bd747967c6bea520ba695c4152e9c3
8283078f93 Make sure window's opener service resolves uris instead of automatically resolving all uris
578c4c0aa8 Merge branch 'sandy081/extensionsSync'
838ea7227c 🧹
da851601ca Remove unused styles
cba214b1aa Update hover dirty tab state
cb8902ab4f Remove line ref to old icon
6856708e74 Adopt icon font in search viewlet
79dbd4d7c0 Replace todo
e62f2e3e2e Only require a reviver being registered to revive a webview
a62b7dabe7 Make resolveExternalUri return just a plain uri instead of a disposable result
041c20c476 Update close and dirty state icons in explorer and tabs
858db5c1ac fix default
00983bcdf0 Fixes microsoft/vscode-remote-release#1400: Allow UI extensions to run remotely
e5383cf2ce :lipstick:
ba355efafb :lipstick:
24eb4d1628 a setting to enable/disable extensions sync
950733209d Handle ctrl/cmd + c
7535d8329d Merge branch 'master' into sandy081/extensionsSync
a0c3a3ee42 Simplify logic and address feedback
d91cf948ba Merge remote-tracking branch 'origin/master' into misolori/icon-font-explorer
0216598efb Show correct chevron icon when panel position is on right
8c09945efc Rename to My Account extensions
4841135999 Remove uninstall everywhere action
d63f900f52 auto uninstall extension everywhere
86f66d6c81 Breakpoint supported should live on SessionData in the breakpoint
aca8ed82ca Update localize JSDoc example to match signature
ff2509cf61 fix typo
17479a0b59 UI to remove a synced extension and show synced extensions
96cbd952fe Add missing spaces to view mode switcher tooltip
944a1a58a8 Remove workaround for IE (#71553 #81272)
fe5315badc Ship codicon with the standalone editor
7d305b0f18 use computed remote to update remote contents
36872a05e8 :lipstick:
a42ce9b9da get the extension from local when removed in remote
806d4fd5cd implement extensions sync
14d47d35a9 fixes #79239
6884154c84 Be explicit about certain things to help the editor tree-shaking
f84d6a4105 fix #80583
a5ea66dee5 Refactor file dialog service to fix layer breaker (#81171)
de03947834 fix bad map values
372cc4722e :lipstick:
464b501835 update distro
bcb7b8cdd9 Show collapse icon in custom tree views
6ba3ce9658 Update lightbulb color token names
fd16fee02a Fix #80394
ce6319c76c Merge branch 'master' into git_branch_name
797ab73e1c Fix #80389
86fa120cdd Fix #81129
a817a588c7 Moving resolve uri logic into openerService
6710df4460 Allow tunneling when clicking on links in the terminal
93ba04b2b0 Move extractLocalHostUriMetaDataForPortMapping up to tunnel service
36bf392f6d Make standard tunnel service re-use tunnels when possible
9bc376219d Extra OpenOptions types
3e8beed32a Use arrow function to avoid needing $this
5693b09a67 Extract shouldOpenExternal
9b7585518f Remove ext setting
03c444e89a Adopt icon font in explorer
1577637026 Polish trusted setting wording
81ec777df2 support merge code lens for vscode-userdata
c04457c1f5 Fix url validation logic
d352e4013b Use check icon to complete merge
c93fb8cb36 Fix #80551
d5f0a93032 Fix #81246
e9b8a06e09 Fix #81122
a47886c5da fix build
e0cdfa58ba formatting
70f3a0970d Fix microsoft/vscode-remote-release#1444
208a139a99 update distro
e791b6c5e0 Add a message that would reduce the grace time
54c3db1285 fileEditorInput: do more caching and drop cache when new formatter registered
f144b5d525 createMemoizer so we can clear
95d7625a27 Merge branch 'joao/scm-tree'
ef326b9057 scm: restore scrollTop
04bfb983d7 scm tree: proper icon theme alignment
b590547d8a debug: more async and polish
3a7ac68889 tree: fix npe
98d411476d Merge pull request #81165 from kke/patch-1
f555f5d2c6 extensions sync
f20785db31 always use the uriFormat; fixes #79596
1c4c8ceb93 breakpoints: bound in some process
bcf67c867f allow trailing commas in tsconfig.json (for #80419)
7186fef89d cleanup
cb70fd5ef0 rename allowTrailingsCommas -> allowTrailingCommas
210de88488 compressible object tree: fix keyboard navigation for new nodes
df6d49c1b1 index tree: fix splice issue with filtered nodes
ff570b5881 variables: respect errorMessage
aa75677a69 tree: improve compressible keyboard label navigation provider
0d85351dc4 simple IPC: allow to encode static context (windowId)
809bb971f9 debugActions: minor polish
5f9452eff5 fixes #81195
a7e892744c Add description for tasks dependsOn
5e72f65eda debt - represented filename and document edited is electron only
25369137ee Merge pull request #81156 from ATheCoder/fix-81077
31206840fc Merge branch 'master' into fix-81077
086af301aa Fix #81080
1c6938e342 debt - reload() to host service
e1f4b03780 debt - implement toggleFullScreen() properly
575062278d fix #81123
b399f710a1 debt - fix call to pick folder and open
7e99bd32f0 Make IEditor.setSelections take a readonly array
f2b1bb269d Marking array types as readonly
99ee26ce10 Only create elements array once
1f4ef6a0ca Marking return values readonly
db11576dbc Use null instead of undefined for openCodeEditor
0fdba0997c `getActiveCodeEditor` should return undefined instead of null
b18ef0e734 Make `getFocusedCodeEditor` return undefined instead of null
5aee2f0a5a Re-render extension editor readme when theme changes
ea01b3949e Extract renderMarkdown
af47c6c2b1 Convert to async
8d9d072e25 Syntax highlight code blocks on extension pages
8f6108beea Removing unused .mac style rule for rendered markdown
92dac9e20e Make sure we don't reparent the webview in the extension editor
4cb8e380b1 Use Schemas instead of strings
19517ca01c More comments
3d655792fb Allow selection on completion detail. Fix #55853
e2a2c5804d Update diff next/prev to use icon font
b27dca7164 Merge pull request #81191 from microsoft/misolori/icon-font-lighbulb
681328102c Adopt icon font in lightbulbs
75bd6f2097 Merge pull request #81062 from microsoft/misolori/icon-font-notif
ad1cb1f661 Make sure exthost has same id for webview as main thread
f08ed9e254 Merge branch 'master' into misolori/icon-font-notif
46f41f1fcf Move color styles to respective areas
1588f08724 Show close button on PR comments
20010646d6 web - do not open our website for first time users
3334b82562 debt - remove resolveProxy from window service
a55b7ecf69 fixes #80921
1ad5b21b5a node-debug@1.38.8
798e32cb83 code.sh: pipe error still printed. For https://github.com/microsoft/vscode-remote-release/issues/1420
a9c67d8b82 extHost startDebugging minor polish
c4a6fc1078 Merge pull request #80673 from dgozman/fix-62419
4f04524fd7 do not inline touchbar icons - does not work
78f9269daf node-debug@1.38.7
8fb28a37e9 debt - picking and opening file/folder/workspace is an electron thing
6f24ffa034 Fix terminalProcess typo "exectuableVerification"
f882a95952 debt - require electron and not Electron
af00f97482 debt - temporary allow IElectronService in file dialog service
d58aa5ebe0 debt - use electron dialogs through electron service
c411dd7918 fix: #81077
ceb795a88f Fix commit
a3d141c179 Improve custom tree view fileIcon event fix
bd8f87e90f Custom views are doing work too early
2c42211762 debt - handle devtools via electron service
5de60c1be4 web - fix broken static extensions
6ba021ba32 Add more scopes to themes based on feedback for C++ and discussion
69fa361afe use final 1.37 version of DAP modules
29d6e21a77 node-debug@1.38.6
9088dbe366 breakpoints: comments and a minor fix
c1fdabc4f2 Update themes with c++ scopes based on discussion
ba439b2406 breakpoint widget: focus input on change context to make it more user friendly
accd8597f0 debug: dispose context menu actions on hide. Also some breakpoint polish
c2dcd0ba67 icon > codicon (fixes #81142)
8cd4c5a4f2 debt - windowsService => legacyWindowsMainService
e69400a2e2 debt - launchService => launchMainService
443ab8f33e debt - extract a openEmptyWindow method and support in web
6a81e81b03 initialize statu
c813ee9ca7 Start extensions sync
83c0e378d0 Serialize-friendly interface
715b6c5792 Add extension id that triggered the activation event
c8fa927f76 debt - have methods for restart, relaunch
e211ef116e :lipstick:
72177d7730 ipc - adopt simple proxy for menubar service
f47e7345f1 web - disable DownloadURL for now (crashes PWA, produces empty files)
0d76b1f9ed debt - remove old legacy layout (thanks for the time being)
67c431e3a5 Merge branch 'master' into misolori/icon-font-notif
8b6e0efc0a Update folding icon to use icon font
6de911e329 Remove pre 1.37 webview state restore logic
1fee5ab5b8 Webviews should prefer to keep their ids across serialize-deserialize
6a94ca4699 Delegate to embedder when resolving if one exists
27bac598cc Basic implementation of `resolveExternalUri`
16577caa8c Mark immutable fields as readonly
36b66c90e9 Add firstOrDefault helper
766352d992 Use disposableStore in a few more places
e9ac00c6ee Remove unused disposable fields
50a4606318 Fix comment
44d0f1b6d9 Remove redundant property init
9d09c13a70 Prefer using Disposable.None vs custom noop disposable
1eb87b0e9c update distro
75e94ddcff Fix #81126
637cf42712 Fix #69970
ffbf5ab2f9 Merge pull request #81071 from microsoft/misolori/icon-font-find
be144477f2 Merge branch 'master' into misolori/icon-font-find
73e4513e49 Merge pull request #79735 from harujii/font-family-jp
0ea6bdcc0e Merge branch 'master' into misolori/icon-font-find
68ee8e9111 Update class for peek view icons
981a429576 Fix #81117, show close icon in peek view
ded2de95dc Merge branch 'master' into font-family-jp
b10bf696e4 VSCode Insiders breaks into Chrome developer tools with "TypeError: Cannot read property 'layout' of undefined". Fixes #81063
1573b6bb1c Scope icon colors and update naming convention
e33e3a83f3 Merge branch 'master' into misolori/icon-font-notif
003a1acd23 Increase Extension Octicon size to be visible
f973ba7fb5 Update `tools` Octicon to be an outline
e4d4b43f35 Allow debug session to share repl with its parent; fixes #62419
bbb56dba81 web - preserve pathname in URL when opening windows or changing workspaces
cd0f833fe0 title - introduce remoteName as variable
95e877c12b Merge branch 'master' into sandy081/httpEndPointSync
b5a0ab0c94 debt - introduce IHostService and distinguish between web and desktop
9c85ca3757 breakpoint inline candidate polish
451bf9cbda wip: bug
425beff313 scm: fix count
c72500318f scm: fix tree sort order
75eece48af object tree model: use mergeSort
911a161f14 fix list sorting
b5b28c3c88 remove underline
6a54c8176f Update action label classes
ed37c661f4 scm: properly handle action context
bcaf812131 breakpoints: make the candidate breakpoints look more clickable
fa2b3c30ad Merge branch 'master' of github.com:Microsoft/vscode
6789fa2218 Make .icon inline-block
fb7991a3fd debt - bring back macOS custom title menu
afde7913eb build - set no-sandbox everywhere (#81096)
c3d611c7ad debt - introduce and use simpleIpcProxy
a0e65a532d breakpoints: update decorations with a minor timeout to react once to multiple nearby events
1e10216856 trigger sync after closing the conflicts editor
7f182c40a9 debug brekpoints: polish inline breakpoint decorations
7ccfc2dcc5 remove user data api implementation
d9ec15cda4 debt - introduce simple IPC helpers for basic communication forwarding using proxys
c0072b61ee use if match and if not match headers
6d7917cd3c Add some C++ scopes to dark+ and light+ themes
ced9fdfa4f scm: folder context actions
23d1760117 debt - first cut extract showIteminFolder
8940dc827d fix file dialogs
88e8f36e2d use if modified headers
bcd7bcedff wip: scm folder menus
cc481ab31b Remove unused icon references
701b16af3b fix bad ref
76a09c0038 fix icon paths
c894376361 fix settings merging
88ff4a7bdd Fix #80525
db358b5b02 Fixing a mismatch in default config for webviews
5fc4fe2266 Add resolveExternalUri embedder contribution point
f4766766b4 Auto sync in web
6b2da9bc55 Use userRoamingDataHome
8937b39776 Pass content type header
073a6efc80 Store last sync data in file
e6ad711936 Adopt icon font in find widget
927f8d87a8 Move user data sync to shared process
57a4fec362 scm: render paths in list mode
79934c9807 scm: ToggleViewModeAction
9a60edcf0a fix padding
73357b8a90 ResourceTree :lipstick:
33deade905 :lipstick:
6982e2fe23 :lipstick:
39e58d5244 scm: pin
7e9687c115 AbstractTree.onDidPin
513f68803c Update icon color descriptions
99a3db6eaa :lipstick:
ed0f669972 cleanup, add context menu actions back
86baf83904 Update distro
7dd72f3586 Merge pull request #81058 from microsoft/misolori/codicon-refs
d0feca912c Adopt icon font in notifications
b920133a68 read and write user data using sync store endpoint
0b795b1bec scm: reorg
a62c6ee148 debt - add openExtensionDevelopmentHostWindow into IExtensionHostDebugService
66a25a0ec1 electron-main renames :lipstick:
945d678d36 uv_pipe_open error when starting code-insiders from WSL microsoft/vscode-remote-release#1420
0fa53a6e66 Update refs to include codicon
74bcfa3aa3 :up: distro
99a7194d4e Remove svg reference
7ecb5821cd debt - remove IWindowService#log in favor of a logger that can log to the main side
874d2fcd3e sketch user data sync store service with log in
36e61492d5 Merge pull request #81018 from microsoft/misolori/icon-font
339e226b76 Merge branch 'master' into misolori/icon-font
6fe6269c41 Keep better track of custom executions for reruns and depends
c9258e86a6 move credentials service to platform
e83d9d3acf breakpoints: render candidates as decorations
64b9f9b00a Revert notification icon change
a2a9ec0eb6 Rename iconDefault => iconForeground
b44a8ca309 move user data sync store to workbench
5cc29271b5 Introduce id and user data sync store registry
50a0bd9eaa debug session: add breakpointLocations
ab1fe2a0c2 scm: flat
9e3d285def breakpoints: interaction on inline breakpoint decorations
a8d5382619 debt - more platform/electron-main cleanup
19fed1d5b0 Include tooltip on custom tree item icon
3e439112ba debt - clean up platform/electron-main (part 1)
96bf508c70 Move remote dialog local commands into remoteFileDialog.ts
aaa40e5c77 scm: keyboard nav
09daf8869e Move remote file dialog local commands to electron browser
f8c9cc7d6a Move TreeView message API to stable
703480e6a1 breakpoints: introduce InlineBreakpointWidget
2105bcef65 debt - introduce electron service and adopt for showMessageBox
6048f0d12e Merge branch 'master' into joao/scm-tree
4aa94e20ed remove unused import
9db2dd5b86 scm: proper folder resources
842db8c39c Merge branch 'master' into joao/scm-tree
227cebfac7 fixes #80671
136600a7bb miss compilation
d8d6c2daad :up: chokidar@3 (#81028)
c38aea395c remote invalid import
b29d98337f :lipstick:
d3e1143171 Move user data sync service to platform
849034f59a electron - fix deprecation warning (accessibility)
753de26cd6 debt - remove some internal commands
08a5964645 web - change API to URI (from UriComponents)
bdd1971f2c :up: distro
663b07c8e9 Update icon ref to codicon
9b9b142852 Scope icon color token
5764546fa6 Remove output style
2320972f5f Revert "Move user data sync service to platform"
a6c689dc5e Revert ":lipstick:"
d54dbd33f4 Add icon for image preview ext
73fdbc9765 Fix another bad  import
b3b0ee5d31 Merge branch 'master' into font-family-jp
0c4d56eebb Meiryo -> Meiryo UI
7eb355846f Address link protection feedbacks
7a9dfd33ee :lipstick:
0772a8fcc9 Move user data sync service to platform
e9e726f659 handle conflicts outside synchroniser
2d6ab9cbcc Fix-80080 Show more detailed error message for "Regex parse error" in search (#80495)
50568aa290 Fix merge conflict
8b22e026a2 move user data sync store service to platform
801585eda1 Add icon default color style
1ee616d802 Don't duplicate external webview commit in so many places
04da82c1d2 Let webview editors show in diff original view too
1961739dfc adopt new terminal API
44eb607fc6 extract settings merge as a service
79e4024d11 Update panel icons to use icon font
4e0de7ce57 web connection
316fd807fe remove docIndex in markdown language extension (#80933)
5bca175608 JSONEditingService: update multiple value
8fbdeb724b move user data sync services to platform
d26e39b355 :lipstick: tests
4ace80eb6a debug: move all bre…
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants