Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
baywet
previously approved these changes
Mar 4, 2024
|
@rkodev can you have a look at what's happening here when you have a couple of minutes please? |
|
@Baywey the issue was tests spefic to go version 1.21 and below. |
baywet
reviewed
Mar 5, 2024
json_serialization_writer_test.go
Outdated
| @@ -303,59 +306,87 @@ func TestEscapeTabAndCarriageReturnInStrings(t *testing.T) { | |||
| // properly encoded as JSON. | |||
| func TestShortEscapeSequencesInString(t *testing.T) { | |||
| // Expected results for each test are quoted since it's a JSON string. | |||
| skipTestCheck := func() bool { | |||
There was a problem hiding this comment.
why don't we upgrade our CI from go1.19 to 1.22 instead?
(not suggesting to upgrade the package go version)
|
@dependabot recreate |
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/go_modules/github.com/stretchr/testify-1.9.0
branch
from
35640ef
to
1e72375
Compare
|
|
This pull request has conflicting changes, the author must resolve the conflicts before this pull request can be merged. |
|
@dependabot recreate |
|
Looks like github.com/stretchr/testify is up-to-date now, so this is no longer needed. |
auto-merge was automatically disabled
March 21, 2024 06:56
Pull request was closed
dependabot
bot
deleted the
dependabot/go_modules/github.com/stretchr/testify-1.9.0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/stretchr/testify from 1.8.4 to 1.9.0.
Release notes
Sourced from github.com/stretchr/testify's releases.
... (truncated)
Commits
bb548d0Merge pull request #1552 from stretchr/dependabot/go_modules/github.com/stret...814075fbuild(deps): bump github.com/stretchr/objx from 0.5.1 to 0.5.2e045612Merge pull request #1339 from bogdandrutu/uintptr5b6926dMerge pull request #1385 from hslatman/not-implements9f97d67Merge pull request #1550 from stretchr/release-notesbcb0d3fInclude the auto-release notes in releasesfb770f8Merge pull request #1247 from ccoVeille/typos85d8bb6fix typos in comments, tests and github templatese2741faMerge pull request #1548 from arjunmahishi/msgAndArgs6e59f20http_assertions: assert that the msgAndArgs actually works in testsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)