Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- simplified field deserializers #1

Merged
merged 1 commit into from Apr 5, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Expand Up @@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

## [0.2.0] - 2022-04-04

### Changed

- Breaking: simplifies the field deserializers.

## [0.1.0] - 2022-03-30

### Added
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Expand Up @@ -4,7 +4,7 @@ go 1.17

require (
github.com/google/uuid v1.3.0
github.com/microsoft/kiota-abstractions-go v0.1.0
github.com/microsoft/kiota-abstractions-go v0.2.0
github.com/stretchr/testify v1.7.1
)

Expand Down
2 changes: 2 additions & 0 deletions go.sum
Expand Up @@ -11,6 +11,8 @@ github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/microsoft/kiota-abstractions-go v0.1.0 h1:oaUAitWTfV/v9nuyF8Et5d74/n8jDTrQ/yGfttFmkW0=
github.com/microsoft/kiota-abstractions-go v0.1.0/go.mod h1:72wco+cRPd6SJf6R2wjEQT/BzbpfCGJQ/MGJixj+AIM=
github.com/microsoft/kiota-abstractions-go v0.2.0 h1:5zg8SLQBUfAvg0wP6vH42k97pjCZ6sI5yBC7QOovsXM=
github.com/microsoft/kiota-abstractions-go v0.2.0/go.mod h1:72wco+cRPd6SJf6R2wjEQT/BzbpfCGJQ/MGJixj+AIM=
github.com/microsoft/kiota/abstractions/go v0.0.0-20211129093841-858bd540489b h1:K6kuW1GATRCuYinEFsAdjnTvpRM2FTyefRjkCj/sqIc=
github.com/microsoft/kiota/abstractions/go v0.0.0-20211129093841-858bd540489b/go.mod h1:pIT6aBVb0aHisY52bSbYvb0nyxe+TqdZ8lkpKB7pLIo=
github.com/microsoft/kiota/abstractions/go v0.0.0-20220124135025-cd414c7de3e7 h1:jKAoSM2Hh64v9Gl1houx5RGtWOkZZwDlOUXqDk1iajI=
Expand Down
2 changes: 1 addition & 1 deletion json_parse_node.go
Expand Up @@ -191,7 +191,7 @@ func (n *JsonParseNode) GetObjectValue(ctor absser.ParsableFactory) (absser.Pars
itemAdditionalData[key] = value.value
}
} else {
err := field(result, value)
err := field(value)
if err != nil {
return nil, err
}
Expand Down