Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there some way to globally override default 100s timeout #70

Closed
meain opened this issue Mar 17, 2023 · 3 comments · Fixed by #71
Closed

Is there some way to globally override default 100s timeout #70

meain opened this issue Mar 17, 2023 · 3 comments · Fixed by #71
Assignees
Labels
question Further information is requested

Comments

@meain
Copy link
Contributor

meain commented Mar 17, 2023

From microsoftgraph/msgraph-sdk-go#302 (comment) and #24 , looks like the library by default adds a 100s timeout if none is present. I understand that we can pass a context with a Deadline, but this becomes a problem when we have to do this for all requests. I was hoping to use the Timeout in http client instead of a context deadline. Is there some way to globally override this 100s timeout?

Other references:

@baywet baywet added the question Further information is requested label Mar 17, 2023
@rkodev
Copy link
Contributor

rkodev commented Mar 20, 2023

Hi @meain, thanks for your interest in the SDK. We currently don't have a way to define a global deadline, a PR is however out that should be able to address your request #71

@baywet baywet linked a pull request Mar 20, 2023 that will close this issue
@meain
Copy link
Contributor Author

meain commented Mar 20, 2023

Awesome, thanks @rkodev.

@meain
Copy link
Contributor Author

meain commented Mar 21, 2023

Thanks for the quick fix, but there is one more item that I would like to address which is regarding setting empty timeout. Is there some way to avoid setting a timeout. We were using 0 value for http.Timeout for downloading large files so as to ensure that it would not timeout (until the server decides to), but I don't think that would be possible here anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants