Setting infinite context timeout

[meain]

This issue is a follow-up for #70 . Thanks for the quick solution for the original issue. What is the opinion on not setting a context timeout if the http timeout is 0?

Since the library sets the timeout to 100, I think we can assume that if we get a value of 0 for http timeout, it is because the user explicitly overrode the value to 0. As of now, if the user sets the timeout to 0 assuming it to get infinite timeout (for example to download large files) it will fail for all requests as it will end up setting a context deadline 0s into the future.

Do let me know if there is some specific reasoning behind the original 100s timeout that I am missing. I was not able to find the reason for the original change in the linked issue.

/cc @rkodev

[rkodev]

Hi @meain, following up on the question, we do have some work in progress that should introduce functionality for large file uploads as mentioned here microsoftgraph/msgraph-sdk-go-core#12.

For now, if you want to execute a long running operation, you do need to use a context.WithTimeout to override the current deadline, you can specify a very large duration i.e 5 minutes, or setup the same at client level.
Setting a 0 timeout at the client level will force you to provide timeouts for all requests since 0 at client level acts differently at context level. It is not possible to remove timeouts on all the request as this is generally not good practice.

[meain]

Setting a 0 timeout at the client level ...

My bad, I was not clear. The question was regarding setting a 0 timeout for specific requests. I do understand that setting it globally might not be sound idea. What we have currently is to set a large timeout for the specific request.

I would also like to highlight the fact that as of now setting http timeout to 0 will cause the requests to fail as it will set deadline to 0 time units into the future.