Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure 3XX responses without location header do not throw #163

Open
baywet opened this issue Mar 21, 2024 · 8 comments
Open

ensure 3XX responses without location header do not throw #163

baywet opened this issue Mar 21, 2024 · 8 comments
Assignees
Labels
bug Something isn't working Standard GitHub label Issue caused by core project dependency modules or library

Comments

@baywet
Copy link
Member

baywet commented Mar 21, 2024

follow up to microsoft/kiota#4367
and microsoft/kiota#4190

Implement a unit test with a 304 response, no location header, check the request adapter returns null and doesn't throw.
Most likely this line will need to be adapted.

if response.StatusCode < 400 {

@baywet baywet added bug Something isn't working Standard GitHub label Issue caused by core project dependency modules or library labels Mar 21, 2024
@Haimantika
Copy link

Hi @baywet is this issue open for contribution?

@baywet
Copy link
Member Author

baywet commented Mar 21, 2024

@Haimantika yes!

@Haimantika
Copy link

@Haimantika yes!

Amazing. How can I assign it to myself? My go skills are rusty, but I would love to give it a try.

@baywet
Copy link
Member Author

baywet commented Mar 21, 2024

You can't because of permissions, but I just assigned it to you for the time being. Let us know if you have any question!

@Haimantika
Copy link

Hi @baywet this is what I am planning to check in the unit test:

  1. Check 304 response
  2. Check if no location header present
  3. Check if it is throwing null and not throwing any error.

Let me know if I am thinking correctly or I need to take a different route.

@baywet
Copy link
Member Author

baywet commented Mar 25, 2024

That'd be perfect! thanks for taking this on.

@Haimantika
Copy link

That'd be perfect! thanks for taking this on.

Hi @baywet apologies I missed this notification. I am currently in a conference, will try to raise a PR by early next week.

@Haimantika
Copy link

@baywet just raised a PR. I think this should be all. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Standard GitHub label Issue caused by core project dependency modules or library
Projects
Status: Todo 📃
Development

No branches or pull requests

2 participants