Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] [Abstractions] Untyped Nodes #149

Merged
merged 8 commits into from
Mar 20, 2024
Merged

[Go] [Abstractions] Untyped Nodes #149

merged 8 commits into from
Mar 20, 2024

Conversation

andrueastman
Copy link
Member

@andrueastman andrueastman commented Feb 8, 2024

This PR is related to microsoft/kiota#2319

It adds a number of types that implement the Parsable interface to enable the representation of types that are unknown at generation time to unblock the serialization and deserialization of properties of unknown types.

Generation of these types is unblocked in microsoft/kiota#4095

Partially resolves microsoftgraph/msgraph-sdk-go#473

@andrueastman andrueastman changed the title [WIP] Untyped Nodes [Go] [Abstractions] Untyped Nodes Mar 4, 2024
@andrueastman andrueastman marked this pull request as ready for review March 4, 2024 18:36
@andrueastman andrueastman requested a review from rkodev March 6, 2024 11:43
serialization/untyped_boolean.go Outdated Show resolved Hide resolved
serialization/untyped_boolean.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@andrueastman andrueastman merged commit f0350b5 into main Mar 20, 2024
7 of 8 checks passed
@andrueastman andrueastman deleted the untypedNodes branch March 20, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Issue with values field for xlsx file using golang SDK
3 participants