Merge pull request #32 from microsoft/fix/pass-request-option-by-ref

Adds getter and setter to response handler pointer
microsoft · Sep 14, 2022 · d3af23c · d3af23c
2 parents 1134b6b + 44a28cf
commit d3af23c
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 6 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -22,3 +22,6 @@ jobs:
       - name: Build SDK project
         run: go build
         working-directory: ${{ env.relativePath }}
+      - name: Test SDK
+        run: go test
+        working-directory: ${{ env.relativePath }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+## [0.10.1] - 2022-09-14
+
+### Changed
+
+- Fix: Add getter and setter on `ResponseHandler` pointer .
+
 ## [0.10.0] - 2022-09-02
 
 ### Added

diff --git a/request_handler_option.go b/request_handler_option.go
@@ -12,22 +12,22 @@ var ResponseHandlerOptionKey = RequestOptionKey{
 }
 
 type requestHandlerOption struct {
-	responseHandler ResponseHandler
+	handler ResponseHandler
 }
 
 // NewRequestHandlerOption creates a new RequestInformation object with default values.
 func NewRequestHandlerOption() RequestHandlerOption {
 	return &requestHandlerOption{}
 }
 
-func (r requestHandlerOption) GetResponseHandler() ResponseHandler {
-	return r.responseHandler
+func (r *requestHandlerOption) GetResponseHandler() ResponseHandler {
+	return r.handler
 }
 
-func (r requestHandlerOption) SetResponseHandler(responseHandler ResponseHandler) {
-	r.responseHandler = responseHandler
+func (r *requestHandlerOption) SetResponseHandler(responseHandler ResponseHandler) {
+	r.handler = responseHandler
 }
 
-func (r requestHandlerOption) GetKey() RequestOptionKey {
+func (r *requestHandlerOption) GetKey() RequestOptionKey {
 	return ResponseHandlerOptionKey
 }