Update NuGet Package Content and Metadata #143
Conversation
| <WarningsAsErrors /> | ||
| <DebugType>Portable</DebugType> | ||
| <LangVersion>8.0</LangVersion> | ||
| <Authors>Microsot Health Team</Authors> |
There was a problem hiding this comment.
This value is freeform and doesn't need to be related to any user in the feed/nuget.org. Does anyone have another value they'd like to use here?
| <HighEntropyVA>true</HighEntropyVA> | ||
| <EnableSourceLink Condition="$([MSBuild]::IsOSPlatform('osx'))">false</EnableSourceLink> |
There was a problem hiding this comment.
Does this work on OSX now?
There was a problem hiding this comment.
Looking at SourceLink's issues page, the only potential issue I found was related to mono: dotnet/sourcelink#155. This has since been fixed, so I think we're good to go.
| @@ -17,14 +17,14 @@ steps: | |||
| displayName: 'dotnet build $(buildConfiguration)' | |||
| inputs: | |||
| command: build | |||
| arguments: '--configuration $(buildConfiguration) /p:AssemblyVersion="$(assemblySemVer)" /p:FileVersion="$(assemblySemFileVer)" /p:InformationalVersion="$(informationalVersion)" /warnaserror' | |||
| arguments: '--configuration $(buildConfiguration) /p:AssemblyVersion="$(assemblySemVer)" /p:FileVersion="$(assemblySemFileVer)" /p:InformationalVersion="$(informationalVersion)" /p:ContinuousIntegrationBuild=true /warnaserror' | |||
There was a problem hiding this comment.
This flag sets determinism-related flags that would only apply on a CI server, like deterministic source paths, etc.
| @@ -1,6 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <Description>Identity primitives used by Microsoft Health.</Description> | |||
There was a problem hiding this comment.
Maybe something like Identity primitives used by Microsoft Health for local development scenarios.
There was a problem hiding this comment.
Sounds good! Changed to Identity primitives used by Microsoft Health for local development.
| <PackageReference Include="Newtonsoft.Json.Schema" Version="3.0.13" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="$(SdkPackageVersion)" /> |
There was a problem hiding this comment.
Re: Normalize .csproj identation to 2 spaces
What is the default? Will this play nice with everyone's editors, is there a settings file to make this consistent?
There was a problem hiding this comment.
It should, as this is the default (and most of the other files were using this). However, we may want to consider the use of an .editorconfig file in the near future, perhaps as part of another PR.
| @@ -3,8 +3,6 @@ | |||
| <PropertyGroup> | |||
| <TargetFrameworks>$(SupportedFrameworks);</TargetFrameworks> | |||
| <NoWarn>$(NoWarn);NU1603</NoWarn> | |||
| </PropertyGroup> | |||
| <PropertyGroup> | |||
| <DefineConstants>R5</DefineConstants> | |||
There was a problem hiding this comment.
I guess while we're here, is there anything that depends on <DefineConstants>R5</DefineConstants>? That was a concept we are using in the FHIR repo
There was a problem hiding this comment.
I don't see it being used. I'll remove it
Description
The NuGet packages are missing some important metadata that would make development easier, and some of the dependencies are incorrect. This PR sets out to address the following:
Related issues
N/A
Testing