Features/bugfixes to support LCOW GCS tests #1360
Conversation
helsaawy
force-pushed
the
he/funcsupport
branch
from
52be33c
to
ff246ed
Compare
helsaawy
force-pushed
the
he/funcsupport
branch
from
ff246ed
to
4c9252c
Compare
helsaawy
changed the title
helsaawy
force-pushed
the
he/funcsupport
branch
from
4c9252c
to
d11d405
Compare
|
Rebased to resolve conflict |
|
Is the winio bump needed to get the tests up and running (or just fixes a longstanding issue with windows and linux ctrs in this repo)? I'd prefer to just have a separate pr/commit for that if possible where the description goes over what's in the new payload and what it fixes for us here instead of being jumbled with this |
Exposed data and functionality for testing GCS: * `internal\guest\runtime\hcsv2.Container.InitProcess()` * `internal\guest\runtime\hcsv2.GetOrAddNetworkNamespace()` * `internal\guest\runtime\hcsv2.RemoveNetworkNamespace()` * `internal\guest\runtime\hcsv2.Host.SecurityPolicyEnforcer()` * `internal\guest\runtime\hcsv2.Host.Transport()` Fixed bug where `host.RemoveContainer` did not remove the network namespace for standalone and pod containers. Updated go-winio version to include bugfixes for closing hvsockets, specifically to close a socket for writing (needed by internal\cmd to signal that the stdin stream has finished). Added doc.go files to guest packages to prevent linter/compiler errors under windows. The tests themselves are broken out here: microsoft#1352 microsoft#1351 Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Yeah, its needed to get the tests running. The functional tests were hanging cause of the bug in hvsock where we dont close the pipes properly (microsoft/go-winio#231) |
Exposed data and functionality for testing GCS:
internal\guest\runtime\hcsv2.Container.ID()internal\guest\runtime\hcsv2.Container.InitProcess()internal\guest\runtime\hcsv2.GetOrAddNetworkNamespace()internal\guest\runtime\hcsv2.RemoveNetworkNamespace()internal\guest\runtime\hcsv2.Host.SecurityPolicyEnforcer()internal\guest\runtime\hcsv2.Host.Transport()Broke out
internal\guest\runtime\runc\runc.gointorunc.go,process.go, andcontainer.go.Fixed bug where
host.RemoveContainerdid not remove the networknamespace for standalone and pod containers.
Updated go-winio version to include bugfixes for closing hvsockets,
specifically to close a socket for writing (needed by internal\cmd
to signal that the stdin stream has finished).
Tests are in these PRs: #1352 #1351
PR Broken off from: #1349
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com