Specify go_package in its full path #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Our linter did not enjoy this for some reason 😰 |
|
Maybe the time to disable the cache? containerd/containerd@56f95e3 |
|
Could be, I'm seeing some issues related to staticcheck not playing nice with 1.18 which looks like this run picked up for the go version. google/pprof#662 |
|
Hmm golangci/golangci-lint#2438. Might be worthwhile to just use 1.17.x instead of ^1.17.0 for our ci maybe until there's support. Let me screw around with this in a branch |
|
@kzys Ok a quick rebase and we should be back in business |
The newer version of protoc-gen-go doesn't support the current form. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
@dcantah Thanks! Rebased. |
dcantah
approved these changes
Apr 11, 2022
anmaxvl
approved these changes
Apr 11, 2022
anmaxvl
added a commit
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newer version of protoc-gen-go doesn't support the current form.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com