Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for security policy enforcement #1325

Merged
merged 3 commits into from Apr 8, 2022

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Mar 12, 2022

Add basic positive and negative tests for security policy enforcement.

Signed-off-by: Maksim An maksiman@microsoft.com

@anmaxvl anmaxvl requested a review from a team as a code owner March 12, 2022 01:13
@anmaxvl anmaxvl force-pushed the tests/basic-security-policy-tests branch from cc2bd61 to 1c2ea78 Compare March 14, 2022 22:16
Copy link
Contributor

@ambarve ambarve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment but otherwise LGTM!

test/cri-containerd/policy_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@helsaawy helsaawy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree with Amit that configOpt and co should be part of securitypolicy. But otherwise, LGTM

@anmaxvl anmaxvl force-pushed the tests/basic-security-policy-tests branch 2 times, most recently from 17307b5 to 29f6c8f Compare April 6, 2022 17:47
@dcantah
Copy link
Contributor

dcantah commented Apr 6, 2022

Linters failing as some of the go tooling didn't have support for 1.18, and ^1.17.0 is resolving to 1.18 now in our CI. golangci/golangci-lint#2438

Add basic positive and negative tests for security policy enforcement.

Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl force-pushed the tests/basic-security-policy-tests branch from 29f6c8f to 77e0f86 Compare April 7, 2022 17:16
@anmaxvl anmaxvl merged commit 70b87e3 into microsoft:master Apr 8, 2022
@anmaxvl anmaxvl deleted the tests/basic-security-policy-tests branch April 8, 2022 01:07
anmaxvl pushed a commit that referenced this pull request Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants