chore: allow React 18 in peerDependencies #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size reportUnchanged fixtures
|
layershifter
force-pushed
the
chore/allow-18-in-peer
branch
from
7133306
to
df5553f
Compare
layershifter
commented
Oct 26, 2022
Comment on lines
2
to
3
| "type": "none", | ||
| "comment": "fix: update dependencies in @griffel/devtools", |
layershifter
force-pushed
the
chore/allow-18-in-peer
branch
from
df5553f
to
674c933
Compare
layershifter
force-pushed
the
chore/allow-18-in-peer
branch
from
674c933
to
255553b
Compare
layershifter
commented
Oct 26, 2022
Comment on lines
+10
to
+11
| "devDependencies": { | ||
| "@griffel/react": "^1.4.1" |
There was a problem hiding this comment.
This package should not have dependencies at all as we bundle it into application. The problem is that import/no-extraneous-dependencies cannot be configured for that case 🗿
This config will read root package.json and will still complain about missing @griffel/react. That's why I left @griffel/react here in devDependencies.
P.S. It's also a reason why we don't need a version bump: artifacts are not affected.
miroslavstastny
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262.
This PR:
peerDependenciesof@griffel/react@griffel/devtools(check comments for more context)