Rename module to github.com/microsoft/go-winio #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Microsoft GitHub organization uses a lowercase 'm', which other go modules from Microsoft also use. This module using an uppercase M can cause problems in certain build systems when using macOS which uses a case-insensitive build system by default: NixOS/nixpkgs#273998 Signed-off-by: Bouke van der Bijl <i@bou.ke>
|
@helsaawy I was wondering if you could take a look at this? |
I believe renaming the module here will impact anyone who imports it, which is a fairly large and breaking change, as evidenced by the CI failures |
|
Duplicate of PR #159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Microsoft GitHub organization uses a lowercase 'm', which other go modules from Microsoft also use. This module using an uppercase M can cause problems in certain build systems when using macOS which uses a case-insensitive file system by default: NixOS/nixpkgs#273998