Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipe.go: add DialPipeAccessImpLevel #302

Merged
merged 1 commit into from Nov 5, 2023
Merged

Conversation

dblohm7
Copy link
Contributor

@dblohm7 dblohm7 commented Aug 16, 2023

I would like to use impersonation on the server side of the pipe, but I currently cannot because all pipes are connected using the anonymous impersonation level.

This patch adds a new function that provides the ability to explicitly specify the desired impersonation level.

Fixes #297

@dblohm7 dblohm7 requested a review from a team as a code owner August 16, 2023 22:23
@dblohm7
Copy link
Contributor Author

dblohm7 commented Sep 7, 2023

@helsaawy is your team willing to accept this PR?

I would like to use impersonation on the server side of the pipe, but I
currently cannot because all pipes are connected using the anonymous
impersonation level.

This patch adds a new function that provides the ability to explicitly
specify the desired impersonation level.

Fixes microsoft#297

Signed-off-by: Aaron Klotz <aaron@tailscale.com>
@dblohm7
Copy link
Contributor Author

dblohm7 commented Oct 10, 2023

@helsaawy Thanks for the review! Can you merge this, please?

@tylersmalley
Copy link

👋 @msscotb, checking in on this to see if it can be merged.

@msscotb msscotb merged commit 553a715 into microsoft:main Nov 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Ability to specify different impersonation levels for named pipe clients
4 participants