Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign ErrPipeListenerClosed to net.ErrClosed #242

Merged
merged 2 commits into from Apr 20, 2022
Merged

Assign ErrPipeListenerClosed to net.ErrClosed #242

merged 2 commits into from Apr 20, 2022

Commits on Apr 6, 2022

  1. Assign ErrPipeListenerClosed to net.ErrClosed 

    This error used to just be a `errors.New` with the text exactly matching
the "use of closed network connection" that you'd get from the Go stdlib.
Now that that error was exported as `net.ErrClosed` in Go 1.16 we should
be able to swap to this safely, and anyone who relied on checking the
string explicitly should still be fine.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    @dcantah
    dcantah committed Apr 6, 2022
    Copy the full SHA
    02e8aff View commit details
    Browse the repository at this point in the history

  2. CI: Run tests on Go 1.17+ 

    Add in a ^1.17.0 go-version for the actions/setup-go@v2 action. This
was set for our build step but not for the step that runs all of the
unit tests.

Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    @dcantah
    dcantah committed Apr 6, 2022
    Copy the full SHA
    708df50 View commit details
    Browse the repository at this point in the history