Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HV Socket known IDs, Dial, bug fixes #239

Merged
merged 3 commits into from Jul 21, 2022

Commits on Jun 15, 2022

  1. Added HV Socket known IDs, Dial, bug fixes

    Added:
    * Well-know Hyper-V VMIDs for parents, children, and loopback.
    * VSock interop service GUID.
    * `Dial()` and `DialContext()` to dial a specific Hyper-V socket at a
      known address (along with a corresponding `HvsockDialer` struct.
    
    Bug fixes:
    * Dial (and Listen) now properly initialize and set properties of their
      sockets after ConnectEx (and AcceptEx).
    * The `socketError` used by `bind` was incorrect, it should be `int32(-1)`,
      not `uintptr(^0)`
    * Return errors for `(*HvsockConn) SetDeadline`
    
    Created a `sockets` package, currently only with syscalls to `Bind`,
    `ConnectEx` and `GetSockName`, bypassing `syscall/windows` restrictions
    on the types that can do so.
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Jun 15, 2022
    Copy the full SHA
    9a46672 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. PR: error handling bug, rebase, unexport, naming

    * comments and todos statements
    * spelling
    * removed dead code
    * changed names to be more conventional
    * unexported socket code
    * made `(*HvsockDialer) Dial` take `Context`, removed `DialContext`
    * added default `Dial` function
    * rebased onto main
    * cleaned up `Dial(` retry loop
    
    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Jul 5, 2022
    Copy the full SHA
    a615ab2 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. PR: RawSockaddr validation, .As( style

    Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
    helsaawy committed Jul 13, 2022
    Copy the full SHA
    cdc1225 View commit details
    Browse the repository at this point in the history