Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'OpenVirtualDiskParameters' BOOL fields #226

Merged
merged 2 commits into from Feb 15, 2022

Commits on Dec 4, 2021

  1. Fix 'OpenVirtualDiskParameters' BOOL fields

    While reworking the vhd package I'd mistakingly replaced some of the fields
    in the OpenVersion2 structure with the incorrect types. They're defined as
    Windows BOOLS which is just a type alias for an int, and I'd put their type as
    go bools.
    
    As the type is already passed into some functions, to avoid a breaking change just
    convert the incorrect type to a new structure with the correct definition internally.
    Truthfully this turns out a bit better as supplying a bool makes more sense and is
    more go friendly.
    
    Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    dcantah committed Dec 4, 2021
    Copy the full SHA
    f8931c4 View commit details
    Browse the repository at this point in the history
  2. PR feedback

    Change openVersion2 comment
    
    Signed-off-by: Daniel Canter <dcanter@microsoft.com>
    dcantah committed Dec 4, 2021
    Copy the full SHA
    0252c4c View commit details
    Browse the repository at this point in the history