Add etw UnicodeStringField #211
Conversation
|
|
| // UnicodeStringArray adds an array of UTF-16 strings to the event. | ||
| func UnicodeStringArray(name string, values []string) FieldOpt { | ||
| return func(em *eventMetadata, ed *eventData) { | ||
| em.writeArray(name, inTypeUnicodeString, outTypeString, 0) |
There was a problem hiding this comment.
Do we want the out type here? It looks like TraceLoggingWideString in TraceLoggingProvider.h just uses TlgInUNICODESTRING with no out type.
pavelbazika
force-pushed
the
etw-unicodestring
branch
2 times, most recently
from
724e7f4
to
48d3521
Compare
|
@pavelbazika |
Signed-off-by: Pavel Bazika <kokes@kocovnici.cz>
pavelbazika
force-pushed
the
etw-unicodestring
branch
from
48d3521
to
fc43157
Compare
There was a problem hiding this comment.
Everything looks good except for the linter (and for some reason the signing check expects your email to be different):
Commit sha: fc43157, Author: Pavel Bazika, Committer: Pavel Bazika; Expected "Pavel Bazika pavel.bazika@icewarp.com", but got "Pavel Bazika kokes@kocovnici.cz".
| binary.Write(&ed.buffer, binary.LittleEndian, unicode) | ||
| ed.buffer.Write([]byte{0, 0}) |
There was a problem hiding this comment.
to suppress the linter on error checking (or you can add a //nolint:errcheck directive)
| binary.Write(&ed.buffer, binary.LittleEndian, unicode) | |
| ed.buffer.Write([]byte{0, 0}) | |
| _ = binary.Write(&ed.buffer, binary.LittleEndian, unicode) | |
| _, _ = ed.buffer.Write([]byte{0, 0}) |
Allow to send UTF-16 encoded message. It's the only missing part needed for writing messages with local characters into event log via this library, when string is specified as win:UnicodeString in instrumentation manifest (which cannot be changed).
UnicodeStringArrayis there only for completeness from my point of view.