Better naming for functions

Signed-off-by: Amit Barve <ambarve@microsoft.com>

backuptar/tar.go

@@ -109,9 +109,9 @@ func BasicInfoHeader(name string, size int64, fileInfo *winio.FileBasicInfo) *ta
 	return hdr
 }
 
-// EncodeSDDLFromTarHeader reads the SDDL associated with the header of the current file
-// from the tar header and encodes it into a byte slice.
-func EncodeSDDLFromTarHeader(hdr *tar.Header) ([]byte, error) {
+// SecurityDescriptorFromTarHeader reads the SDDL associated with the header of the current file
+// from the tar header and returns the security descriptor into a byte slice.
+func SecurityDescriptorFromTarHeader(hdr *tar.Header) ([]byte, error) {
 	// Maintaining old SDDL-based behavior for backward
 	// compatibility.  All new tar headers written by this library
 	// will have raw binary for the security descriptor.
@@ -132,9 +132,9 @@ func EncodeSDDLFromTarHeader(hdr *tar.Header) ([]byte, error) {
 	return sd, nil
 }
 
-// EncodeExtendedAttributesFromTarHeader reads the EAs associated with the header of the
-// current file from the tar header and encodes it into a byte slice.
-func EncodeExtendedAttributesFromTarHeader(hdr *tar.Header) ([]byte, error) {
+// ExtendedAttributesFromTarHeader reads the EAs associated with the header of the
+// current file from the tar header and returns it as a byte slice.
+func ExtendedAttributesFromTarHeader(hdr *tar.Header) ([]byte, error) {
 	var eas []winio.ExtendedAttribute
 	var eadata []byte
 	var err error
@@ -394,7 +394,7 @@ func FileInfoFromHeader(hdr *tar.Header) (name string, size int64, fileInfo *win
 func WriteBackupStreamFromTarFile(w io.Writer, t *tar.Reader, hdr *tar.Header) (*tar.Header, error) {
 	bw := winio.NewBackupStreamWriter(w)
 
-	sd, err := EncodeSDDLFromTarHeader(hdr)
+	sd, err := SecurityDescriptorFromTarHeader(hdr)
 	if err != nil {
 		return nil, err
 	}
@@ -413,7 +413,7 @@ func WriteBackupStreamFromTarFile(w io.Writer, t *tar.Reader, hdr *tar.Header) (
 		}
 	}
 
-	eadata, err := EncodeExtendedAttributesFromTarHeader(hdr)
+	eadata, err := ExtendedAttributesFromTarHeader(hdr)
 	if err != nil {
 		return nil, err
 	}