Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(OverflowItem): properly propagate refs to child elements #31347

Merged
merged 2 commits into from May 14, 2024

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented May 13, 2024

New Behavior

  • Fixes ref forwarding in a scenario when *Trigger components are used (adds .isFluentTriggerComponent)
  • Fixes refs on child elements (calls child.ref)
  • New tests have been added

Related Issue(s)

Fixes #31346

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 13, 2024
@layershifter layershifter marked this pull request as ready for review May 13, 2024 10:07
@layershifter layershifter requested a review from a team as a code owner May 13, 2024 10:07
@fabricteam
Copy link
Collaborator

fabricteam commented May 13, 2024

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 631 623 5000
Button mount 307 304 5000
Field mount 1144 1104 5000
FluentProvider mount 698 715 5000
FluentProviderWithTheme mount 80 82 10
FluentProviderWithTheme virtual-rerender 37 41 10
FluentProviderWithTheme virtual-rerender-with-unmount 73 79 10
MakeStyles mount 857 858 50000
Persona mount 1765 1750 5000
SpinButton mount 1395 1405 5000
SwatchPicker mount 1520 1555 5000

Copy link

codesandbox-ci bot commented May 13, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 13, 2024

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: entire library
1.139 MB
275.337 kB
1.139 MB
275.371 kB
89 B
34 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-breadcrumb
@fluentui/react-breadcrumb - package
117.263 kB
32.241 kB
react-components
react-components: Button, FluentProvider & webLightTheme
71.55 kB
20.584 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
221.825 kB
62.568 kB
react-components
react-components: FluentProvider & webLightTheme
44.037 kB
14.418 kB
react-overflow
hooks only
12.87 kB
4.83 kB
react-portal-compat
PortalCompatProvider
8.39 kB
2.64 kB
🤖 This report was generated against bf854a4b7ba1ac057f57a21527cf1d0240c14d9b

@fabricteam
Copy link
Collaborator

fabricteam commented May 13, 2024

🕵 fluentuiv9 No visual regressions between this PR and main

@layershifter layershifter enabled auto-merge (squash) May 14, 2024 09:34
@layershifter layershifter merged commit 426d003 into microsoft:master May 14, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: OverflowItem does not propagate refs
4 participants