-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modifies useHeadlessFlatTree
return signature to include getItem
method
#31343
Merged
bsunderhus
merged 3 commits into
microsoft:master
from
bsunderhus:react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
May 17, 2024
Merged
feat: modifies useHeadlessFlatTree
return signature to include getItem
method
#31343
bsunderhus
merged 3 commits into
microsoft:master
from
bsunderhus:react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
FluentProviderWithTheme | virtual-rerender | 37 | 38 | 10 | Possible regression |
All results
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 650 | 615 | 5000 | |
Button | mount | 301 | 301 | 5000 | |
Field | mount | 1089 | 1105 | 5000 | |
FluentProvider | mount | 708 | 693 | 5000 | |
FluentProviderWithTheme | mount | 83 | 83 | 10 | |
FluentProviderWithTheme | virtual-rerender | 37 | 38 | 10 | Possible regression |
FluentProviderWithTheme | virtual-rerender-with-unmount | 79 | 70 | 10 | |
MakeStyles | mount | 883 | 837 | 50000 | |
Persona | mount | 1775 | 1725 | 5000 | |
SpinButton | mount | 1382 | 1376 | 5000 | |
SwatchPicker | mount | 1546 | 1579 | 5000 |
📊 Bundle size report
Unchanged fixtures
|
bsunderhus
force-pushed
the
react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
branch
from
May 13, 2024 08:51
45344cc
to
23c227f
Compare
bsunderhus
force-pushed
the
react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
branch
from
May 14, 2024 11:29
14641b8
to
81deb5c
Compare
bsunderhus
force-pushed
the
react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
branch
from
May 14, 2024 11:30
81deb5c
to
8abe771
Compare
bsunderhus
changed the title
feat: adds getItem to HeadlessFlatTree (breaking change)
feat: exposes dependency to May 15, 2024
createHeadlessTree
bsunderhus
changed the title
feat: exposes dependency to
feat: modifies May 17, 2024
createHeadlessTree
useHeadlessFlatTree
return signature to include getItem
method
bsunderhus
force-pushed
the
react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
branch
from
May 17, 2024 11:47
ec48a28
to
0fea79b
Compare
layershifter
approved these changes
May 17, 2024
fabricteam
reviewed
May 17, 2024
bsunderhus
force-pushed
the
react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
branch
from
May 17, 2024 12:16
0fea79b
to
3a17a59
Compare
bsunderhus
deleted the
react-tree/feat--adds-getItem-to-HeadlessFlatTree-(breaking-change)
branch
May 17, 2024 14:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
Currently the only ways to get a headless tree item from the headless tree are:
.items()
method.getNextNavigableItem()
methodNew Behavior
useHeadlessFlatTree
to include.getItem
method that allow trying to locate the headless tree itemRelated Issue(s)