New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(public-docsite-v9): Add disclaimer that strict mode is not supported #25243
docs(public-docsite-v9): Add disclaimer that strict mode is not supported #25243
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b6daa72:
|
📊 Bundle size report🤖 This report was generated against 643aff32bdf62c90367408c060e24b92c6005380 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 643aff32bdf62c90367408c060e24b92c6005380 (build) |
…to ssr/docs-disclaimer
|
||
### Strict mode | ||
|
||
Strict mode is currently not supported. To avoid hydration issues, disable strict mode in your app by adding the following configuration to your `next.config.js` file: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ling1726, I think the main difference is that those 2 bugs are specific to Strict Mode in React 18 vs the SSR issues existing in Strict Mode for any version of React.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are specific to Strict Mode in React 18
@khmakoto actually those issues I linked also happen for strict mode in 17 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ling1726 Updated it to be in the quickstart and refer to all repo.
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
…to ssr/docs-disclaimer
…rted (microsoft#25243) * docs: Add disclaimer that strict mode is not supported. * updating disclaimer to be in the quickstart instead * minor update * Update apps/public-docsite-v9/src/Concepts/QuickStart.stories.mdx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
This PR adds a disclaimer that strict mode is not currently supported and how to disable it. This came from this issue that shows how in strict mode, v9 components do not hydrate correctly.
Note: Once the issue is fixed, this disclaimer should be removed.
Related Issue(s)
Fixes #24955