Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(public-docsite-v9): Add disclaimer that strict mode is not supported #25243

Merged
merged 6 commits into from Oct 19, 2022

Conversation

sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented Oct 14, 2022

This PR adds a disclaimer that strict mode is not currently supported and how to disable it. This came from this issue that shows how in strict mode, v9 components do not hydrate correctly.

Note: Once the issue is fixed, this disclaimer should be removed.

Related Issue(s)

Fixes #24955

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 14, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b6daa72:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 14, 2022

📊 Bundle size report

🤖 This report was generated against 643aff32bdf62c90367408c060e24b92c6005380

@size-auditor
Copy link

size-auditor bot commented Oct 14, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 643aff32bdf62c90367408c060e24b92c6005380 (build)


### Strict mode

Strict mode is currently not supported. To avoid hydration issues, disable strict mode in your app by adding the following configuration to your `next.config.js` file:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have open bugs in strict mode like #24085 or #25232

So the disclaimer should rather be applied to the entire library and not just SSR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ling1726, I think the main difference is that those 2 bugs are specific to Strict Mode in React 18 vs the SSR issues existing in Strict Mode for any version of React.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are specific to Strict Mode in React 18

@khmakoto actually those issues I linked also happen for strict mode in 17 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ling1726 Updated it to be in the quickstart and refer to all repo.

sopranopillow and others added 2 commits October 19, 2022 10:49
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@sopranopillow sopranopillow merged commit e25d1d3 into microsoft:master Oct 19, 2022
@sopranopillow sopranopillow deleted the ssr/docs-disclaimer branch October 19, 2022 17:36
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
…rted (microsoft#25243)

* docs: Add disclaimer that strict mode is not supported.

* updating disclaimer to be in the quickstart instead

* minor update

* Update apps/public-docsite-v9/src/Concepts/QuickStart.stories.mdx

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR: Add disclaimer for strictmode in docs
6 participants