chore: improve error message in useIsSSR() #23750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0371306:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1337 | 1323 | 5000 | |
| Button | mount | 1003 | 1009 | 5000 | |
| FluentProvider | mount | 1710 | 1763 | 5000 | |
| FluentProviderWithTheme | mount | 670 | 663 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 647 | 650 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 675 | 674 | 10 | |
| MakeStyles | mount | 2075 | 2069 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ba6c5d651559b91c815429c9a9357c4d5a390f3e (build) |
ling1726
approved these changes
Jun 29, 2022
marcosmoura
pushed a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 29, 2022
…ect-amout-of-items * master: chore: improve error message in useIsSSR() (microsoft#23750) fix: Codesandbox exports should use ^9.0.0 (microsoft#23764) applying package updates Update BadgeColor.stories.tsx (microsoft#23762) chore(react-avatar): Adding unit and vr tests for AvatarGroup (microsoft#23549) docs(react-avatar): Adding readme and migration guide for AvatarGroup (microsoft#23758) update deps after 9.0.1 release (microsoft#23756) applying package updates fix: Use caret dependency range for Griffel (microsoft#23754) Theme designer: minor fixes (microsoft#23741) fix: Dependency mismatch after 9.0.0 release (microsoft#23752)
khmakoto
pushed a commit
to khmakoto/fluentui
that referenced
this pull request
Jul 13, 2022
khmakoto
pushed a commit
to khmakoto/fluentui
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR improves an error that can be thrown by
useIsSSR()hook to include source and documentation link as was suggested in #23620 (comment).