Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update Webpack to latest #18919

Merged
merged 3 commits into from Jul 14, 2021
Merged

chore: update Webpack to latest #18919

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d5e931b
chore: update Webpack to latest
layershifter Jul 12, 2021
bcce163
tweak env variable
layershifter Jul 13, 2021
154c569
dedupe terser, terser-webpack-plugin, acorn & enhanced-resolve
layershifter Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Expand Up @@ -186,7 +186,7 @@
"tsconfig-paths-webpack-plugin": "3.5.1",
"tslib": "2.2.0",
"typescript": "4.1.5",
"webpack": "5.21.2",
"webpack": "5.44.0",
"webpack-bundle-analyzer": "4.4.2",
"webpack-cli": "4.3.1",
"webpack-dev-middleware": "4.2.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/fluentui/digest/package.json
View file
Open in desktop
Expand Up @@ -19,8 +19,7 @@
},
"dependencies": {
"just-scripts": "1.3.1",
"querystring": "^0.2.0",
"webpack": "5.21.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks redundant as we have the same version on root...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be there because digest was intended to be published at some point? Though looks like it's not published now, so agreed it's not needed.

"querystring": "^0.2.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion scripts/webpack/webpack.config.e2e.ts
View file
Open in desktop
Expand Up @@ -40,7 +40,7 @@ const webpackConfig: webpack.Configuration = {
],
},
plugins: [
new webpack.DefinePlugin(getDefaultEnvironmentVars()),
new webpack.DefinePlugin(getDefaultEnvironmentVars(true)),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we run this build only in production this override is required, otherwise it's causing:

verb @fluentui/e2e test |  WARNING in DefinePlugin
verb @fluentui/e2e test |  Conflicting values for 'process.env.NODE_ENV'
verb @fluentui/e2e test |  '"development"' !== '"production"'
verb @fluentui/e2e test |

new ForkTsCheckerWebpackPlugin({
typescript: {
configFile: paths.e2e('tsconfig.json'),
Expand Down