Accordion Convergence #16969
Merged
Accordion Convergence #16969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsunderhus
requested review from
dzearing,
ecraig12345,
JustSlone and
xugao
as code owners
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6c126d0:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1148bc99d2dd9a9d8452ab1d95d83e7d9ab6cf1d (build) |
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
ling1726
reviewed
Feb 16, 2021
ling1726
reviewed
Feb 16, 2021
ling1726
reviewed
Feb 16, 2021
ling1726
reviewed
Feb 16, 2021
ecraig12345
reviewed
Feb 25, 2021
ecraig12345
reviewed
Mar 2, 2021
change/@fluentui-react-accordion-0dc572ee-df54-4e96-923d-db68fe030532.json
Outdated
Show resolved
Hide resolved
|
Seems like @reach/descendants requires Typescript 3.8, due to Type-only Export. #16101 may be required. |
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 3, 2021
layershifter
reviewed
Mar 9, 2021
packages/react-accordion/src/components/AccordionHeader/DefaultExpandIcon.tsx
Outdated
Show resolved
Hide resolved
layershifter
reviewed
Mar 9, 2021
packages/react-accordion/src/components/AccordionHeader/DefaultExpandIcon.tsx
Show resolved
Hide resolved
ecraig12345
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
LGTM from a build perspective once the issues @layershifter mentioned about versions are addressed.
Also mentioned this in a thread comment but repeating here so it doesn't get buried: it might be worth filing a syncpack issue asking for an explicit option determining how to resolve mismatches (we usually prefer newest, but others might prefer most popular). The author has been pretty helpful in the past. https://github.com/JamieMason/syncpack
…sunderhus/accordion-convergence � Conflicts: � packages/react-examples/package.json
layershifter
approved these changes
Mar 10, 2021
packages/react-accordion/src/components/Accordion/useAccordionStyles.ts
Outdated
Show resolved
Hide resolved
miroslavstastny
approved these changes
Mar 11, 2021
JustSlone
approved these changes
Mar 11, 2021
|
🎉 Handy links: |
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
* Scaffold react-accordion project * Writes initial Spec * Change files * Updates API * Bumps version of dependencies * Update Test * Updates API * Updates spec * Updates Spec * Update deps * Delete components * Add components scaffolding * Update AccordionHeader * Updates button slot * Updates accordion header and item * Update Accordion context * Update Accordion context * Add examples * Update packages/react-accordion/package.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update packages/react-accordion/tsconfig.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update dependencies and version * Update accordion logic * Change useRef for useConst * Update change/@fluentui-react-accordion-0dc572ee-df54-4e96-923d-db68fe030532.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update packages/react-accordion/jest.config.js Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Adds ability helpers to react-accordion examples * Update styles and spec * Update spec * Update styles * Add to AccordionHeader children as a slot * Update packages/react-accordion/Spec.md Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/package.json Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/package.json Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/src/components/Accordion/useAccordionContext.ts Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update specs * use useControllable hook to control Accordion open state * Update versions * Lint * Updates accordion internals to normalize indexes * updates API * Change files * Updates Accordion comments * Fix sb problems with withCompatThemeProvider * Adds AccordionHeader common props to Accordion context * Adds rendering test * Update AccordionContext to use context selector * Adds useAccordion test * Deletes unecessary change files * Fiz prelint issues * Change files * Update Accordion public API * Fix AMD issues * Update packages/react-examples/.storybook/preview.js Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update scripts/format.js Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/package.json Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Bump "@fluentui/react-utilities" dependency version * Update icon * Update DefaultIcon and internal signatures * updates wrongly bumped dependencies * Deletes Cahnge file * Change files * Updates DefaultExpandIcon internal Chevron * Updates public API * Fix tests * fix versions, remove change files, restore changes * Update makeStyles to makeStylesCompat * Removes unused style file * Update snapshot Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
* Scaffold react-accordion project * Writes initial Spec * Change files * Updates API * Bumps version of dependencies * Update Test * Updates API * Updates spec * Updates Spec * Update deps * Delete components * Add components scaffolding * Update AccordionHeader * Updates button slot * Updates accordion header and item * Update Accordion context * Update Accordion context * Add examples * Update packages/react-accordion/package.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update packages/react-accordion/tsconfig.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update dependencies and version * Update accordion logic * Change useRef for useConst * Update change/@fluentui-react-accordion-0dc572ee-df54-4e96-923d-db68fe030532.json Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Update packages/react-accordion/jest.config.js Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> * Adds ability helpers to react-accordion examples * Update styles and spec * Update spec * Update styles * Add to AccordionHeader children as a slot * Update packages/react-accordion/Spec.md Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/package.json Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/package.json Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/src/components/Accordion/useAccordionContext.ts Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update specs * use useControllable hook to control Accordion open state * Update versions * Lint * Updates accordion internals to normalize indexes * updates API * Change files * Updates Accordion comments * Fix sb problems with withCompatThemeProvider * Adds AccordionHeader common props to Accordion context * Adds rendering test * Update AccordionContext to use context selector * Adds useAccordion test * Deletes unecessary change files * Fiz prelint issues * Change files * Update Accordion public API * Fix AMD issues * Update packages/react-examples/.storybook/preview.js Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update scripts/format.js Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Update packages/react-accordion/package.json Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> * Bump "@fluentui/react-utilities" dependency version * Update icon * Update DefaultIcon and internal signatures * updates wrongly bumped dependencies * Deletes Cahnge file * Change files * Updates DefaultExpandIcon internal Chevron * Updates public API * Fix tests * fix versions, remove change files, restore changes * Update makeStyles to makeStylesCompat * Removes unused style file * Update snapshot Co-authored-by: Elizabeth Craig <elcraig@microsoft.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
yarn changeDescription of changes
react-accordionprojectFocus areas to test
Completes some tasks from #16926