fix: update implementation of getReactFiberFromNode to be compatible with React 17 #16392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
requested review from
assuncaocharles,
dzearing,
jurokapsiar,
ling1726,
miroslavstastny and
pompomon
as code owners
msft-fluent-ui-bot
added
the
Fluent UI react-northstar (v0)
layershifter
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 020a5e1:
|
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5feec8dc74dd5db94341c69ca9254e8af210488e (build) |
ling1726
reviewed
Jan 6, 2021
| } | ||
| } | ||
|
|
||
| throw new Error('getReactFiber(): Failed to find a React Fiber on a node'); |
There was a problem hiding this comment.
nit: consider having a test case for the throw
ling1726
approved these changes
Jan 6, 2021
…ix/popper-warning � Conflicts: � packages/fluentui/CHANGELOG.md
|
Which version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16192.
In React 17 internal keys were changed (facebook/react#18377), I performed a small refactor to extract shared code (
PopperandFiberNavigator) to a single place and added unit tests. Also manually tested with React 17.