Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Babel to latest #13985

Merged
merged 5 commits into from Jul 10, 2020
Merged

chore: bump Babel to latest #13985

merged 5 commits into from Jul 10, 2020

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jul 10, 2020

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Related to #12953. This PR bumps all Babel related dependencies to get benefits from babel/babel#11428.

Focus areas to test

(optional)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 10, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c4a279e:

Sandbox Source
Fluent UI Button Configuration
microsoft/fluentui: codesandbox-react-template Configuration

@DustyTheBot
Copy link

DustyTheBot commented Jul 10, 2020

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against c4a279e

@msft-github-bot
Copy link
Contributor

msft-github-bot commented Jul 10, 2020

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 878 841 5000
ButtonNext mount 563 569 5000
Checkbox mount 1503 1614 5000
CheckboxBase mount 1325 1300 5000
CheckboxNext mount 1552 1565 5000
ChoiceGroup mount 4785 4827 5000
ComboBox mount 916 949 1000
CommandBar mount 7869 7718 1000
ContextualMenu mount 16600 16243 1000
DefaultButton mount 1082 1098 5000
DetailsRow mount 3530 3617 5000
DetailsRowFast mount 3495 3383 5000
DetailsRowNoStyles mount 3359 3307 5000
Dialog mount 1523 1529 1000
DocumentCardTitle mount 1824 1880 1000
Dropdown mount 2504 2461 5000
FocusZone mount 1747 1800 5000
IconButton mount 1749 1701 5000
Label mount 337 335 5000
Link mount 450 461 5000
LinkNext mount 446 442 5000
MenuButton mount 1442 1397 5000
Nav mount 3173 3275 1000
Panel mount 1444 1437 1000
Persona mount 848 838 1000
Pivot mount 1409 1422 1000
PivotNext mount 1337 1381 1000
PrimaryButton mount 1311 1233 5000
SearchBox mount 1236 1305 5000
SearchBoxNext mount 1267 1283 5000
Slider mount 1488 1535 5000
SliderNext mount 1914 1930 5000
Spinner mount 441 404 5000
SplitButton mount 3048 3083 5000
Stack mount 516 510 5000
StackWithIntrinsicChildren mount 1873 1919 5000
StackWithTextChildren mount 4861 4818 5000
TagPicker mount 2674 2651 5000
Text mount 408 409 5000
TextField mount 1321 1328 5000
ThemeProvider mount 2870 3023 5000
ThemeProvider virtual-rerender 506 517 5000
Toggle mount 849 854 5000
ToggleNext mount 805 792 5000
button mount 114 118 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🎯 Avatar.Fluent 0.42 0.46 0.91:1 2000 842
🦄 Button.Fluent 0.1 0.19 0.53:1 5000 521
🔧 Checkbox.Fluent 0.62 0.35 1.77:1 1000 623
🎯 Dialog.Fluent 0.15 0.21 0.71:1 5000 767
🔧 Dropdown.Fluent 2.95 0.45 6.56:1 1000 2951
🔧 Icon.Fluent 0.14 0.05 2.8:1 5000 695
🦄 Image.Fluent 0.07 0.11 0.64:1 5000 341
🔧 Slider.Fluent 1.59 0.34 4.68:1 1000 1594
🔧 Text.Fluent 0.06 0.03 2:1 5000 324
🦄 Tooltip.Fluent 0.1 20.47 0:1 5000 485

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AnimationMinimalPerf.default 398 357 1.11:1
BoxMinimalPerf.default 333 305 1.09:1
RadioGroupMinimalPerf.default 431 399 1.08:1
Icon.Fluent 695 651 1.07:1
AttachmentMinimalPerf.default 165 155 1.06:1
TextAreaMinimalPerf.default 457 432 1.06:1
FlexMinimalPerf.default 264 252 1.05:1
PopupMinimalPerf.default 666 635 1.05:1
PortalMinimalPerf.default 125 119 1.05:1
RefMinimalPerf.default 208 199 1.05:1
DialogMinimalPerf.default 772 742 1.04:1
HeaderSlotsPerf.default 764 734 1.04:1
ListWith60ListItems.default 1104 1066 1.04:1
VideoMinimalPerf.default 625 599 1.04:1
CardMinimalPerf.default 567 551 1.03:1
HeaderMinimalPerf.default 353 342 1.03:1
ImageMinimalPerf.default 365 356 1.03:1
SplitButtonMinimalPerf.default 3687 3581 1.03:1
Dialog.Fluent 767 743 1.03:1
AttachmentSlotsPerf.default 1141 1118 1.02:1
ButtonSlotsPerf.default 589 577 1.02:1
ChatWithPopoverPerf.default 484 473 1.02:1
DropdownMinimalPerf.default 2986 2922 1.02:1
HierarchicalTreeMinimalPerf.default 425 416 1.02:1
InputMinimalPerf.default 1105 1082 1.02:1
ItemLayoutMinimalPerf.default 1219 1196 1.02:1
LabelMinimalPerf.default 395 386 1.02:1
ListNestedPerf.default 862 847 1.02:1
ProviderMergeThemesPerf.default 1965 1926 1.02:1
ToolbarMinimalPerf.default 945 926 1.02:1
TooltipMinimalPerf.default 744 733 1.02:1
Button.Fluent 521 513 1.02:1
Slider.Fluent 1594 1568 1.02:1
Text.Fluent 324 319 1.02:1
AccordionMinimalPerf.default 156 155 1.01:1
CarouselMinimalPerf.default 441 438 1.01:1
ChatDuplicateMessagesPerf.default 424 419 1.01:1
DropdownManyItemsPerf.default 757 749 1.01:1
ListMinimalPerf.default 454 451 1.01:1
MenuButtonMinimalPerf.default 1539 1523 1.01:1
IconMinimalPerf.default 630 625 1.01:1
CustomToolbarPrototype.default 3742 3710 1.01:1
Dropdown.Fluent 2951 2918 1.01:1
EmbedMinimalPerf.default 1897 1888 1:1
LayoutMinimalPerf.default 382 382 1:1
TreeMinimalPerf.default 864 860 1:1
Checkbox.Fluent 623 620 1:1
ChatMinimalPerf.default 582 586 0.99:1
GridMinimalPerf.default 314 317 0.99:1
ListCommonPerf.default 920 933 0.99:1
ReactionMinimalPerf.default 366 369 0.99:1
SegmentMinimalPerf.default 329 333 0.99:1
SliderMinimalPerf.default 1544 1561 0.99:1
StatusMinimalPerf.default 641 650 0.99:1
CheckboxMinimalPerf.default 2801 2852 0.98:1
LoaderMinimalPerf.default 710 722 0.98:1
TableManyItemsPerf.default 2164 2197 0.98:1
AlertMinimalPerf.default 298 307 0.97:1
MenuMinimalPerf.default 822 850 0.97:1
ProviderMinimalPerf.default 860 884 0.97:1
TableMinimalPerf.default 378 390 0.97:1
Avatar.Fluent 842 864 0.97:1
Image.Fluent 341 350 0.97:1
Tooltip.Fluent 485 501 0.97:1
AvatarMinimalPerf.default 460 480 0.96:1
ButtonMinimalPerf.default 168 175 0.96:1
DividerMinimalPerf.default 363 386 0.94:1
TextMinimalPerf.default 325 344 0.94:1
FormMinimalPerf.default 357 382 0.93:1
TreeWith60ListItems.default 201 223 0.9:1

@size-auditor
Copy link

size-auditor bot commented Jul 10, 2020

Asset size changes

⚠️ Insufficient baseline data to detect size changes

Unable to find bundle size details for Baseline commit: 77a67dc

Possible causes

  • The baseline build 77a67dc is broken
  • The Size Auditor run for the baseline build 77a67dc was not triggered

Recommendations

  • Please merge your branch for this Pull request with the latest master build and commit your changes once again

Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it seems safe to you. I looked at the yarn.lock and there are no new duplicate versions showing up, so that's good (that problem may mainly come up when trying to bump of one piece of babel to a newer but not newest version).

(Not officially approving so that this doesn't end up getting merged before you're done testing--I don't know how you normally test these changes.)

@dzearing dzearing merged commit b369d4a into master Jul 10, 2020
@dzearing dzearing deleted the chore/babel-bump branch July 10, 2020 22:18
@dzearing
Copy link
Member

dzearing commented Jul 10, 2020

I would like to assume we don't put PRs up that aren't intended to be merged when lights pass, especially without Do Not Merge labels. Merging this to reduce open PRs; if we should have a different policy however, lmk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants