feat(icons): add all svg icons in the @fluentui/react-icons package #12641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: David Zearing <dzearing@microsoft.com>
Co-Authored-By: David Zearing <dzearing@microsoft.com>
Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com>
Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com>
mnajdova
changed the title
# Conflicts: # packages/office-ui-fabric-react/package.json # yarn.lock
…-package-icons # Conflicts: # packages/react-icons/src/components/BorderBlindsIcon.tsx
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 66e61600f1af22b6d49ca87f3bb80b43158a2174 (build) |
# Conflicts: # packages/office-ui-fabric-react/src/components/Icon/examples/Icon.SvgFactory.Example.tsx # packages/react-icons/src/index.ts
-reverted removed icons
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
mnajdova
requested review from
dvdzkwsk,
jurokapsiar,
layershifter,
levithomason,
miroslavstastny and
pompomon
as code owners
dzearing
approved these changes
Apr 17, 2020
|
🎉 Handy links: |
|
🎉 Handy links: |
DuanShaolong
pushed a commit
to DuanShaolong/fluentui
that referenced
this pull request
Apr 27, 2020
…icrosoft#12641) * wip * -added example svg icons * -added props support by diff factory * Update packages/react-icons/src/components/BorderBlindsIcon.tsx Co-Authored-By: David Zearing <dzearing@microsoft.com> * Update packages/react-icons/src/components/BorderBlindsIcon.tsx Co-Authored-By: David Zearing <dzearing@microsoft.com> * Update packages/react-icons/src/utils/createSvgIcon.ts Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com> * Update packages/react-icons/README.md Co-Authored-By: Elizabeth Craig <ecraig12345@gmail.com> * -cleanups -removed circular dependencies * -removed comments * -improvements * -exported utilities * -added icons as react components * -added storybook example with all svg icons * -updated readme * -addressed comments * -added tests * -added dependencies * -removed merge conflicts changes * -picked changes from master * -reverted changes * -updated package json * -removed example icons * -reverted changes in svg factory -reverted removed icons * -reverted some changes * -removed example icons * -reverted unintended changes * Change files * -updated test * -updated snapshots * Change files Co-authored-by: David Zearing <dzearing@microsoft.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is continuing the work from #12608
Things done in this PR:
@fluentui/react-iconspackageOneDriveIcon,YammerIconandBorderBlindsIconcomponents.test.tsx's paths