Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-icons): allow React 18 in peerDependencies #525

Merged
merged 1 commit into from Nov 27, 2022
Merged

fix(react-icons): allow React 18 in peerDependencies #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-icons/package.json
View file
Open in desktop
Expand Up @@ -51,8 +51,7 @@
"tslib": "^2.1.0"
},
"peerDependencies": {
"@griffel/react": "^1.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@griffel/react is gone as it's also in regular dependencies (see line 50).

"react": ">=16.8.0 <=18.0.0"
"react": ">=16.8.0 <19.0.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allows React 18, the same as in @fluentui/react-components, https://github.com/microsoft/fluentui/blob/8fcefaeacac2e2cc2cd7ca5b76c1ca5e7e547682/packages/react-components/react-components/package.json#L80.

},
"files": [
"lib/",
Expand Down Expand Up @@ -83,3 +82,4 @@
}
}
}